[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFC: libescher



-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

[I replyed from pkg-java-maintainers to debian-java because I prefer
pkg-java-maintainers's list to be only for bug reports]

Robert Schuster wrote:
> Hi,
> this patch adds build infos for the escher library which implements the X libs
> in Java. Together with GNU Classpath this provides an AWT (and Swing)
> implementation that uses java.io only.

Wow!

> The escher source archive (0.2.3) is a bit odd. It contains no separate source
> and has all the class files in it. I tried to fix that in the clean rule. Hope
> that makes sense.

That's the way to go.

> Index: libescher-java/debian/control
> ===================================================================
> --- libescher-java/debian/control	(Revision 0)
> +++ libescher-java/debian/control	(Revision 0)
> @@ -0,0 +1,15 @@
> +Source: libescher-java
> +Section: libs
> +Priority: optional
> +Maintainer: Robert Schuster <robert.schuster@tarent.de>

Maintainet: Debian Java Maintainers <pkg-java-maintainers@l.a.d.o>
Uploaders: Robert Schuster <...>

Can you consider joining us in Alioth's project pkg-java?

> +Build-Depends: cdbs, debhelper (>= 4.1.0), java-gcj-compat-dev, ant
> +Standards-Version: 3.6.2

Build-Depends: cdbs, debhelper (>= 4.1.0)
Build-Depends-Indep: java-gcj-compat-dev, ant
Standards-Version: 3.7.2

[...]

> Index: libescher-java/debian/rules
> ===================================================================
> --- libescher-java/debian/rules	(Revision 0)
> +++ libescher-java/debian/rules	(Revision 0)

[...]

> +DEB_JARS := \
> +	ant-launcher

I don't think it's needed anymore.

> +# Build compiler
> +DEB_ANT_COMPILER := org.eclipse.jdt.core.JDTCompilerAdapter
> +ifneq (,$(findstring eclipse,$(DEB_ANT_COMPILER)))
> +    DEB_JARS += ecj.jar /usr/share/ant/lib/ecj-adapter.jar
> +endif

Isn't it the default compiler?

[...]

> Index: libescher-java/debian/README.Debian-source
> ===================================================================
> --- libescher-java/debian/README.Debian-source	(Revision 0)
> +++ libescher-java/debian/README.Debian-source	(Revision 0)
> @@ -0,0 +1,9 @@
> +libescher-java for Debian
> +-------------------------
> +
> +Upstream author provides no separate source-only archive therefore
> +pre-compiled class files and HTML documentation has been removed from the
> +downloaded
> +archive.

Great to comment the way you changed the sources.

Excellent work, I'm ok to sponsor your upload if needed, you can contact
me in private (give me an url with orig.tar.gz and .dsc and diff.gz).

Cheers,

- --
  .''`.
 : :' :rnaud
 `. `'
   `-
Java Trap: http://www.gnu.org/philosophy/java-trap.html
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.3 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFEvgVU4vzFZu62tMIRAk/OAJ9qRGWw6dTNrFoCfv1GBsBn5k5YDgCgjgNk
AKbcKujXHzU52bBJ2K38lo0=
=nG0X
-----END PGP SIGNATURE-----



Reply to: