[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Bug#483290: status of merge?

Le Sat, Jan 03, 2009 at 09:10:18AM +0900, Junichi Uekawa a écrit :
> Cc:'ing debian-japanese: 
> Anyone tried applying the patch against 6.0 and if it works?

Hi all,

I had a look at 6.0d. First of all, it is unredistributable:

  aqwa『unzip-6.0d』$ head README 
  This is a public beta release of UnZip, version 6.00d,  2008 February 17
  ______________________ Cut here for public release _______________________
  This is the README file for the 29 February 2008 public release of the
  Info-ZIP group's portable UnZip zipfile-extraction program (and related
  unzip60.zip       portable UnZip, version 6.0, source code distribution
  unzip60.tar.Z     same as above, but compress'd tar format

(hence the CC to #496989)

Unzip version 6.0d compiles well with the /debian directory of 5.52-12. It
seems to have new Unicode facilities, that can be enabled by compiling with
-DUNICODE_SUPPORT. It adds two options:

  -H  use escapes for all non-ASCII Unicode
  -U  ignore any Unicode fields

I did not manage to make something useful with them.

I downloaded Ubuntu's unzip package (5.52-12ubuntu1) and tested their -O
option. I confirm that it works and is very handy. The option seems to be
implemented by a single patch to unzip.c (and a reciprocal one to zipinfo.c).
The patch does not apply well to the 6.0d source as there are conflicts with
some parts modified to implement UNICODE_SUPPORT.

The Ubuntu's patch works by adding the -O option only when compiled with
-DUNIX, because of many #if(n)def UNIX statements. It is difficult to transpose
it without making it mutually exclusive with UNICODE_SUPPORT or managing
combinations of both. I did not go further. Have Unzip's upstream authors reacted
to this issue? http://www.info-zip.org/zip-bug.html seems to be down…

Have a nice day,

Charles Plessy
Tsurumi, Kanagawa, Japan

Reply to: