[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#981606: marked as done (opencc: reduce Build-Depends)

Your message dated Tue, 02 Feb 2021 17:20:40 +0000
with message-id <E1l6zM0-0006Rv-Ui@fasolo.debian.org>
and subject line Bug#981606: fixed in opencc 1.1.1+git20200624+ds2-5
has caused the Debian Bug report #981606,
regarding opencc: reduce Build-Depends
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
981606: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=981606
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Source: opencc
Version: 1.1.1+git20200624+ds2-4
Tags: patch
User: helmutg@debian.org
Usertags: rebootstrap

opencc participates in dependency loops relevant to architecture
bootstrap. Rather than looking into such a difficult problem, I looked
into easily droppable dependencies.

 * darts is unused, because opencc ships a darts-clone and uses that
   even if a system copy is installed. As such darts can be dropped.
 * graphviz is unused, because the doxyfile now sets HAVE_DOT=NO.
 * jquery is abused. It is used to replace Doxygen's jquery.js.
   Unfortunately, what is called jquery.js is not jquery. Replacing it
   breaks search features in the documentation. Please just drop it.

I'm attaching a patch fixing all of the above for your convenience.

Helmut

diff --minimal -Nru opencc-1.1.1+git20200624+ds2/debian/changelog opencc-1.1.1+git20200624+ds2/debian/changelog
--- opencc-1.1.1+git20200624+ds2/debian/changelog	2021-01-17 23:52:00.000000000 +0100
+++ opencc-1.1.1+git20200624+ds2/debian/changelog	2021-02-01 08:08:52.000000000 +0100
@@ -1,3 +1,14 @@
+opencc (1.1.1+git20200624+ds2-4.1) UNRELEASED; urgency=medium
+
+  * Non-maintainer upload.
+  * Reduce Build-Depends: (Closes: #-1)
+    + Drop graphviz as the doxyfile sets HAVE_DOT=NO.
+    + Do not replace Doxygen's jquery.js (which is not jquery) with something
+      entirely different.
+    + Drop darts dependency as opencc only uses its vendor copy.
+
+ -- Helmut Grohne <helmut@subdivi.de>  Mon, 01 Feb 2021 08:08:52 +0100
+
 opencc (1.1.1+git20200624+ds2-4) unstable; urgency=medium
 
   * Build-depends on pkg-kde-tools to handle symbols.
diff --minimal -Nru opencc-1.1.1+git20200624+ds2/debian/control opencc-1.1.1+git20200624+ds2/debian/control
--- opencc-1.1.1+git20200624+ds2/debian/control	2021-01-17 23:52:00.000000000 +0100
+++ opencc-1.1.1+git20200624+ds2/debian/control	2021-02-01 08:08:52.000000000 +0100
@@ -10,11 +10,8 @@
  xiao sheng wen <atzlinux@sina.com>,
 Build-Depends:
  cmake,
- darts,
  debhelper-compat (= 13),
  doxygen,
- graphviz,
- libjs-jquery,
  libmarisa-dev,
  libtclap-dev,
  python3:any,
@@ -32,7 +29,6 @@
 Architecture: any
 Multi-Arch: same
 Depends:
- libjs-jquery,
  libopencc1.1 (= ${binary:Version}),
  ${misc:Depends},
 Suggests:
@@ -76,7 +72,6 @@
 Section: doc
 Depends:
  ${misc:Depends},
- libjs-jquery,
 Description: simplified-traditional Chinese conversion library - document
  opencc is a library for converting character between traditional Chinese and
  simplified Chinese.
diff --minimal -Nru opencc-1.1.1+git20200624+ds2/debian/rules opencc-1.1.1+git20200624+ds2/debian/rules
--- opencc-1.1.1+git20200624+ds2/debian/rules	2021-01-17 23:52:00.000000000 +0100
+++ opencc-1.1.1+git20200624+ds2/debian/rules	2021-02-01 08:08:52.000000000 +0100
@@ -19,9 +19,6 @@
 		-DBUILD_DOCUMENTATION=ON \
 		-DBUILD_BUNDLED_LIBMARISA=OFF
 
-execute_after_dh_auto_install:
-	ln -sf /usr/share/javascript/jquery/jquery.js debian/tmp/usr/share/opencc/doc/html/jquery.js
-
 execute_after_dh_auto_clean:
 	find . -name *.pyc -delete

--- End Message ---
--- Begin Message --- 
Source: opencc
Source-Version: 1.1.1+git20200624+ds2-5
Done: Boyuan Yang <byang@debian.org>

We believe that the bug you reported is fixed in the latest version of
opencc, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 981606@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Boyuan Yang <byang@debian.org> (supplier of updated opencc package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Tue, 02 Feb 2021 11:58:39 -0500
Source: opencc
Architecture: source
Version: 1.1.1+git20200624+ds2-5
Distribution: unstable
Urgency: medium
Maintainer: Debian Input Method Team <debian-input-method@lists.debian.org>
Changed-By: Boyuan Yang <byang@debian.org>
Closes: 981606
Changes:
 opencc (1.1.1+git20200624+ds2-5) unstable; urgency=medium
 .
   * Team upload.
   * debian/rules: Rewrite to support <!nodoc> build profile.
   * debian/rules: Enable dh_doxygen when building docs.
   * Drop unnecessary build dependencies. (Closes: #981606)
   * debian/control: Mark build-dependency doxygen as <!nodoc>.
   * debian/control: Drop build-dependency on libjs-jquery. Let
     doxygen handle it.
   * debian/control: Drop build-dependency on graphviz. Doxyfile
     did not enable HAVE_DOT.
   * debian/control: Drop build-dependency on dartz. Currently opencc
     uses its vendored copy.
Checksums-Sha1:
 bb5b70e7b4c878ca7004e3df28fdf78ba2a902b6 2516 opencc_1.1.1+git20200624+ds2-5.dsc
 7a136a2d8edb74e33158e76d5bc85f1006706d15 1371379 opencc_1.1.1+git20200624+ds2.orig.tar.gz
 c52cdcb838fc35ae29fa0ab7479d661804792721 13408 opencc_1.1.1+git20200624+ds2-5.debian.tar.xz
 c9f6b18fa7d531b6fcf72355371fe526de5b5a47 9192 opencc_1.1.1+git20200624+ds2-5_amd64.buildinfo
Checksums-Sha256:
 dc0aa4389df9c72ad637ddf8734a8f443e80c03f8ac84d069c2c1086fc9610d6 2516 opencc_1.1.1+git20200624+ds2-5.dsc
 97cd1c369403176f983346d62a9e0e42bba2181bd9fd757f0bc61a4b7bc1ba78 1371379 opencc_1.1.1+git20200624+ds2.orig.tar.gz
 b3e9200cf6fb64f65bf0121c6436ca5e98bd83644c7579823ab647ac1a13bf85 13408 opencc_1.1.1+git20200624+ds2-5.debian.tar.xz
 8c2a6e7d2e850507e43ef37c8a52d197cd56b1123fdca2bb3018b7e22b301145 9192 opencc_1.1.1+git20200624+ds2-5_amd64.buildinfo
Files:
 c670e8a19fbb52ed1ed7723463295e56 2516 libs optional opencc_1.1.1+git20200624+ds2-5.dsc
 26b6f836ca407da2b3c462501baeca5d 1371379 libs optional opencc_1.1.1+git20200624+ds2.orig.tar.gz
 4c9f340af786f7d1e28e532cca44ef22 13408 libs optional opencc_1.1.1+git20200624+ds2-5.debian.tar.xz
 31fe65592f554ef15e985d2492057e60 9192 libs optional opencc_1.1.1+git20200624+ds2-5_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEfncpR22H1vEdkazLwpPntGGCWs4FAmAZhSQACgkQwpPntGGC
Ws5gMw/7BpdDMydc7q+EXr4G0kU65w57sBYDy771MtDCmsPppbj45nfQEynLXRHC
LbfYu8ecn9a6tudnEfuA+yzQK4li2wbQm6IyY3S8AS4gSP9EmMY/xckFS8lgDnqI
rdkQh3elzIYiWCcbcPhcYpWe+pvD2/2DML7sLJ4f3beJ6yTaIjT8tUq/BpXDLtLN
CXVHdjw5077j0iDtNUjAa8o6DLv1Qskf7k8FCSzP6K5dJJEcJlTQ1fqFg4yYx/SI
PnI3wMwS5y4EoENUN/Gojunql7L4u3WDJpYgx6wP4QWAmjAPheFG4PXTXL5YUhX3
l6vcWIzqiGClIEBVP1TUe9ZKYqSmzT36bu2o3ORAweEgCwo8gDB8Yik5JBXFAEF7
qT7hsPwX31oQxaJvfRhgrrT3Ousmf8jrvU61wq/uRmjpXq2Cf2EioZC3TO0XUpM9
fImSa6uhd/BHazjdY2kWd1gsCFfv6hi1ARN6Yr7E7UCC40lwoU01ymZxBGXE6/A6
tvUuQq4SpV20yGA1croTavsNeuFfk9fdc5bGXBdg7GhWlyULdNounWxFn9IekYP+
Tw+QAOQP2HigU2XX742h5n94fInj1qmOp0tVm+IaT0FZP/OzAdQ4bC3cOiNBpIVT
oNWVG7imv8zD5ASLzZL3jF69adYpCUUg6CGCSxNiv4XKH3rx/0w=
=8zxn
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: