[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#981606: opencc: reduce Build-Depends



Source: opencc
Version: 1.1.1+git20200624+ds2-4
Tags: patch
User: helmutg@debian.org
Usertags: rebootstrap

opencc participates in dependency loops relevant to architecture
bootstrap. Rather than looking into such a difficult problem, I looked
into easily droppable dependencies.

 * darts is unused, because opencc ships a darts-clone and uses that
   even if a system copy is installed. As such darts can be dropped.
 * graphviz is unused, because the doxyfile now sets HAVE_DOT=NO.
 * jquery is abused. It is used to replace Doxygen's jquery.js.
   Unfortunately, what is called jquery.js is not jquery. Replacing it
   breaks search features in the documentation. Please just drop it.

I'm attaching a patch fixing all of the above for your convenience.

Helmut
diff --minimal -Nru opencc-1.1.1+git20200624+ds2/debian/changelog opencc-1.1.1+git20200624+ds2/debian/changelog
--- opencc-1.1.1+git20200624+ds2/debian/changelog	2021-01-17 23:52:00.000000000 +0100
+++ opencc-1.1.1+git20200624+ds2/debian/changelog	2021-02-01 08:08:52.000000000 +0100
@@ -1,3 +1,14 @@
+opencc (1.1.1+git20200624+ds2-4.1) UNRELEASED; urgency=medium
+
+  * Non-maintainer upload.
+  * Reduce Build-Depends: (Closes: #-1)
+    + Drop graphviz as the doxyfile sets HAVE_DOT=NO.
+    + Do not replace Doxygen's jquery.js (which is not jquery) with something
+      entirely different.
+    + Drop darts dependency as opencc only uses its vendor copy.
+
+ -- Helmut Grohne <helmut@subdivi.de>  Mon, 01 Feb 2021 08:08:52 +0100
+
 opencc (1.1.1+git20200624+ds2-4) unstable; urgency=medium
 
   * Build-depends on pkg-kde-tools to handle symbols.
diff --minimal -Nru opencc-1.1.1+git20200624+ds2/debian/control opencc-1.1.1+git20200624+ds2/debian/control
--- opencc-1.1.1+git20200624+ds2/debian/control	2021-01-17 23:52:00.000000000 +0100
+++ opencc-1.1.1+git20200624+ds2/debian/control	2021-02-01 08:08:52.000000000 +0100
@@ -10,11 +10,8 @@
  xiao sheng wen <atzlinux@sina.com>,
 Build-Depends:
  cmake,
- darts,
  debhelper-compat (= 13),
  doxygen,
- graphviz,
- libjs-jquery,
  libmarisa-dev,
  libtclap-dev,
  python3:any,
@@ -32,7 +29,6 @@
 Architecture: any
 Multi-Arch: same
 Depends:
- libjs-jquery,
  libopencc1.1 (= ${binary:Version}),
  ${misc:Depends},
 Suggests:
@@ -76,7 +72,6 @@
 Section: doc
 Depends:
  ${misc:Depends},
- libjs-jquery,
 Description: simplified-traditional Chinese conversion library - document
  opencc is a library for converting character between traditional Chinese and
  simplified Chinese.
diff --minimal -Nru opencc-1.1.1+git20200624+ds2/debian/rules opencc-1.1.1+git20200624+ds2/debian/rules
--- opencc-1.1.1+git20200624+ds2/debian/rules	2021-01-17 23:52:00.000000000 +0100
+++ opencc-1.1.1+git20200624+ds2/debian/rules	2021-02-01 08:08:52.000000000 +0100
@@ -19,9 +19,6 @@
 		-DBUILD_DOCUMENTATION=ON \
 		-DBUILD_BUNDLED_LIBMARISA=OFF
 
-execute_after_dh_auto_install:
-	ln -sf /usr/share/javascript/jquery/jquery.js debian/tmp/usr/share/opencc/doc/html/jquery.js
-
 execute_after_dh_auto_clean:
 	find . -name *.pyc -delete
 

Reply to: