[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#835913: ibus: use of dbus-run-session ...



Hi,

Thanks for bug report.

I tried to apply proposed patch but it caused build failure.

---
 .... snip star of build log
Making all in dconf
make[5]: Entering directory '/build/ibus-1.5.19/data/dconf'
LC_ALL=C /usr/bin/intltool-merge  -x -u --no-translations org.freedesktop.ibus.gschema.xml.in org.freedesktop.ibus.gschema.xml
sed \
    -e 's|@VERSION[@]|1.5.19|g' 00-upstream-settings.5.in > 00-upstream-settings.5.tmp && \
    mv 00-upstream-settings.5.tmp 00-upstream-settings.5
sed \
    -e 's|@VERSION[@]|1.5.19|g' ibus.5.in > ibus.5.tmp && \
    mv ibus.5.tmp ibus.5
gzip -c 00-upstream-settings.5 > 00-upstream-settings.5.gz.tmp && mv 00-upstream-settings.5.gz.tmp 00-upstream-settings.5.gz
gzip -c ibus.5 > ibus.5.gz.tmp && mv ibus.5.gz.tmp ibus.5.gz
Merging translations into org.freedesktop.ibus.gschema.xml.
CREATED org.freedesktop.ibus.gschema.xml
/usr/lib/x86_64-linux-gnu/glib-2.0/glib-compile-schemas --strict --dry-run  --schema-file=org.freedesktop.ibus.gschema.xml && mkdir -p . && touch org.freedesktop.ibus.gschema.valid
dbus-run-session -- ./make-dconf-override-db.sh > 00-upstream-settings || \
	{ rc=$?; rm -f -rf 00-upstream-settings; exit $rc; }
dbus[22693]: Unable to set up transient service directory: XDG_RUNTIME_DIR "/run/user/1000" not available: No such file or directory

(process:22700): dconf-CRITICAL **: 23:09:54.363: unable to create directory '/run/user/1000/dconf': Permission denied.  dconf will not work properly.

 .... snip errors ...
(process:22710): dconf-CRITICAL **: 23:09:54.371: unable to create directory '/run/user/1000/dconf': Permission denied.  dconf will not work properly.

(process:22710): dconf-CRITICAL **: 23:09:54.371: unable to create directory '/run/user/1000/dconf': Permission denied.  dconf will not work properly.
kill: usage: kill [-s sigspec | -n signum | -sigspec] pid | jobspec ... or kill -l [sigspec]
make[5]: *** [Makefile:809: 00-upstream-settings] Error 2
rm 00-upstream-settings.5 ibus.5
make[5]: Leaving directory '/build/ibus-1.5.19/data/dconf'
---

Do you know how this XDG_RUNTIME_DIR thing?

Osamu
From: Simon McVittie <smcv@debian.org>
Date: Mon, 29 Aug 2016 10:07:40 +0100
Subject: [PATCH] use dbus-run-session to set up dconf overrides

As described in <https://lists.debian.org/debian-devel/2016/08/msg00554.html>
I'm trying to reduce how much dbus-launch is used in Debian.
This package currently uses dbus-launch to run some infrastructure bits.

https://bugs.debian.org/835913

Signed-off-by: Osamu Aoki <osamu@debian.org>
---
 data/dconf/Makefile.am               | 2 +-
 data/dconf/make-dconf-override-db.sh | 4 +---
 2 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/data/dconf/Makefile.am b/data/dconf/Makefile.am
index 433d993..8182da0 100644
--- a/data/dconf/Makefile.am
+++ b/data/dconf/Makefile.am
@@ -41,7 +41,7 @@ org.freedesktop.ibus.gschema.xml.in: $(top_srcdir)/data/ibus.schemas.in
 
 00-upstream-settings: $(srcdir)/make-dconf-override-db.sh | $(gsettings_SCHEMAS)
 	@$(MKDIR_P) db
-	$(AM_V_GEN) $(srcdir)/make-dconf-override-db.sh > $@ || \
+	$(AM_V_GEN) dbus-run-session -- $(srcdir)/make-dconf-override-db.sh > $@ || \
 		{ rc=$$?; $(RM) -rf $@; exit $$rc; }
 
 man_5_in_files = 00-upstream-settings.5.in ibus.5.in
diff --git a/data/dconf/make-dconf-override-db.sh b/data/dconf/make-dconf-override-db.sh
index 9c650e9..6c1c168 100755
--- a/data/dconf/make-dconf-override-db.sh
+++ b/data/dconf/make-dconf-override-db.sh
@@ -12,9 +12,7 @@ export XDG_CACHE_HOME="$TMPDIR/cache"
 export GSETTINGS_SCHEMA_DIR="$TMPDIR/schemas"
 mkdir -p $XDG_CONFIG_HOME $XDG_CACHE_HOME $GSETTINGS_SCHEMA_DIR
 
-eval `dbus-launch --sh-syntax`
-
-trap 'rm -rf $TMPDIR; kill $DBUS_SESSION_BUS_PID' ERR
+trap 'rm -rf $TMPDIR' ERR
 
 # in case that schema is not installed on the system
 glib-compile-schemas --targetdir "$GSETTINGS_SCHEMA_DIR" "$PWD"
-- 
2.20.1


Reply to: