[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: utf8-migration-tool: [PATCH] remove the codeset and modifier of the current locale

ma, 2007-01-08 kello 16:49 +0100, Nicolas François kirjoitti:

> Also, by looking at the code, I can find a few places were utf8migrationtool
> should fail and quit:
>  * if the .dmrc is not found, the code will fail

Would creating the file and then moving on to the following step
(checking system language) be appropriate, then, rather than fail?

>  * if the locale is not found in the .dmrc, utf8migrationtool uses
>    locale.getlocale(locale.LC_ALL), which is not allowed according to the
>    locale.getlocale() specification (this is probably the cause of #405878

Should it check for LANG then?

>  * if the locale is not found finally, it's not useful to assume that the
>    locale is "C" because in that case, no conversion is needed.

It should probably become en_US.UTF-8 if the locale if not found in
either .dmrc or the system environment.

Martin-Éric Racine

Reply to: