Re: [PATCH 1/2] (GNU/Hurd) add max length hack.

[Samuel Thibault <sthibault@debian.org>]

Samuel Thibault, le lun. 10 févr. 2025 12:44:45 +0100, a ecrit:
> Hello,
> 
> Yuqian Yang, le lun. 10 févr. 2025 17:46:32 +0800, a ecrit:
> > ---
> >  libpam/include/pam_hurd_max_stub.h               | 11 +++++++++++
> >  modules/pam_debug/tst-pam_debug-retval.c         |  1 +
> >  modules/pam_deny/tst-pam_deny-retval.c           |  1 +
> >  modules/pam_echo/tst-pam_echo-retval.c           |  1 +
> >  modules/pam_faildelay/tst-pam_faildelay-retval.c |  1 +
> >  modules/pam_localuser/tst-pam_localuser-retval.c |  1 +
> >  modules/pam_mkhomedir/tst-pam_mkhomedir-retval.c |  1 +
> >  modules/pam_nologin/tst-pam_nologin-retval.c     |  1 +
> >  modules/pam_permit/tst-pam_permit-retval.c       |  1 +
> >  modules/pam_rootok/tst-pam_rootok-retval.c       |  1 +
> >  modules/pam_warn/tst-pam_warn-retval.c           |  1 +
> >  modules/pam_xauth/pam_xauth.c                    |  4 ++++
> >  tests/tst-dlopen.c                               |  4 +---
> >  13 files changed, 26 insertions(+), 3 deletions(-)
> >  create mode 100644 libpam/include/pam_hurd_max_stub.h
> > 
> > diff --git a/libpam/include/pam_hurd_max_stub.h b/libpam/include/pam_hurd_max_stub.h
> > new file mode 100644
> > index 00000000..c3c9b510
> > --- /dev/null
> > +++ b/libpam/include/pam_hurd_max_stub.h
> > @@ -0,0 +1,11 @@
> > +#ifndef PAM_HURD_MAX_STUB_H
> > +#define PAM_HURD_MAX_STUB_H
> > +
> > +/*
> > + * Define PATH_MAX if not available
> > + */
> > +#ifndef PATH_MAX
> > +#define PATH_MAX 4096
> > +#endif
> 
> It'd  be better to make tests use getcwd(NULL), which is in posix since
> 2008.

Ah, sorry, no, it's a glibc extension. Bleh.
I don't know if pam is really used on a system which doesn't have this
extension. Maybe check if musl and friends have it.

Samuel