Re: [PATCH 1/2] (GNU/Hurd) add max length hack.
Hello,
Yuqian Yang, le lun. 10 févr. 2025 17:46:32 +0800, a ecrit:
> ---
> libpam/include/pam_hurd_max_stub.h | 11 +++++++++++
> modules/pam_debug/tst-pam_debug-retval.c | 1 +
> modules/pam_deny/tst-pam_deny-retval.c | 1 +
> modules/pam_echo/tst-pam_echo-retval.c | 1 +
> modules/pam_faildelay/tst-pam_faildelay-retval.c | 1 +
> modules/pam_localuser/tst-pam_localuser-retval.c | 1 +
> modules/pam_mkhomedir/tst-pam_mkhomedir-retval.c | 1 +
> modules/pam_nologin/tst-pam_nologin-retval.c | 1 +
> modules/pam_permit/tst-pam_permit-retval.c | 1 +
> modules/pam_rootok/tst-pam_rootok-retval.c | 1 +
> modules/pam_warn/tst-pam_warn-retval.c | 1 +
> modules/pam_xauth/pam_xauth.c | 4 ++++
> tests/tst-dlopen.c | 4 +---
> 13 files changed, 26 insertions(+), 3 deletions(-)
> create mode 100644 libpam/include/pam_hurd_max_stub.h
>
> diff --git a/libpam/include/pam_hurd_max_stub.h b/libpam/include/pam_hurd_max_stub.h
> new file mode 100644
> index 00000000..c3c9b510
> --- /dev/null
> +++ b/libpam/include/pam_hurd_max_stub.h
> @@ -0,0 +1,11 @@
> +#ifndef PAM_HURD_MAX_STUB_H
> +#define PAM_HURD_MAX_STUB_H
> +
> +/*
> + * Define PATH_MAX if not available
> + */
> +#ifndef PATH_MAX
> +#define PATH_MAX 4096
> +#endif
It'd be better to make tests use getcwd(NULL), which is in posix since
2008.
Samuel
> +#endif
> diff --git a/modules/pam_debug/tst-pam_debug-retval.c b/modules/pam_debug/tst-pam_debug-retval.c
> index e83c89d5..ae5772a3 100644
> --- a/modules/pam_debug/tst-pam_debug-retval.c
> +++ b/modules/pam_debug/tst-pam_debug-retval.c
> @@ -11,6 +11,7 @@
> #include <string.h>
> #include <unistd.h>
> #include <security/pam_appl.h>
> +#include <pam_hurd_max_stub.h>
>
> #define MODULE_NAME "pam_debug"
> #define TEST_NAME "tst-" MODULE_NAME "-retval"
> diff --git a/modules/pam_deny/tst-pam_deny-retval.c b/modules/pam_deny/tst-pam_deny-retval.c
> index 665fcef4..3fa29591 100644
> --- a/modules/pam_deny/tst-pam_deny-retval.c
> +++ b/modules/pam_deny/tst-pam_deny-retval.c
> @@ -11,6 +11,7 @@
> #include <string.h>
> #include <unistd.h>
> #include <security/pam_appl.h>
> +#include <pam_hurd_max_stub.h>
>
> #define MODULE_NAME "pam_deny"
> #define TEST_NAME "tst-" MODULE_NAME "-retval"
> diff --git a/modules/pam_echo/tst-pam_echo-retval.c b/modules/pam_echo/tst-pam_echo-retval.c
> index 8264cb0e..acceffd0 100644
> --- a/modules/pam_echo/tst-pam_echo-retval.c
> +++ b/modules/pam_echo/tst-pam_echo-retval.c
> @@ -11,6 +11,7 @@
> #include <string.h>
> #include <unistd.h>
> #include <security/pam_appl.h>
> +#include <pam_hurd_max_stub.h>
>
> #define MODULE_NAME "pam_echo"
> #define TEST_NAME "tst-" MODULE_NAME "-retval"
> diff --git a/modules/pam_faildelay/tst-pam_faildelay-retval.c b/modules/pam_faildelay/tst-pam_faildelay-retval.c
> index 72b16ef9..a73876ad 100644
> --- a/modules/pam_faildelay/tst-pam_faildelay-retval.c
> +++ b/modules/pam_faildelay/tst-pam_faildelay-retval.c
> @@ -11,6 +11,7 @@
> #include <string.h>
> #include <unistd.h>
> #include <security/pam_appl.h>
> +#include <pam_hurd_max_stub.h>
>
> #define MODULE_NAME "pam_faildelay"
> #define TEST_NAME "tst-" MODULE_NAME "-retval"
> diff --git a/modules/pam_localuser/tst-pam_localuser-retval.c b/modules/pam_localuser/tst-pam_localuser-retval.c
> index f6c22f97..1f576ab4 100644
> --- a/modules/pam_localuser/tst-pam_localuser-retval.c
> +++ b/modules/pam_localuser/tst-pam_localuser-retval.c
> @@ -12,6 +12,7 @@
> #include <string.h>
> #include <unistd.h>
> #include <security/pam_appl.h>
> +#include <pam_hurd_max_stub.h>
>
> #define MODULE_NAME "pam_localuser"
> #define TEST_NAME "tst-" MODULE_NAME "-retval"
> diff --git a/modules/pam_mkhomedir/tst-pam_mkhomedir-retval.c b/modules/pam_mkhomedir/tst-pam_mkhomedir-retval.c
> index 282c5cd0..ada30f9b 100644
> --- a/modules/pam_mkhomedir/tst-pam_mkhomedir-retval.c
> +++ b/modules/pam_mkhomedir/tst-pam_mkhomedir-retval.c
> @@ -14,6 +14,7 @@
> #include <pwd.h>
> #include <sys/stat.h>
> #include <security/pam_appl.h>
> +#include <pam_hurd_max_stub.h>
>
> #define MODULE_NAME "pam_mkhomedir"
> #define TEST_NAME "tst-" MODULE_NAME "-retval"
> diff --git a/modules/pam_nologin/tst-pam_nologin-retval.c b/modules/pam_nologin/tst-pam_nologin-retval.c
> index 4d44a380..47e3f2d1 100644
> --- a/modules/pam_nologin/tst-pam_nologin-retval.c
> +++ b/modules/pam_nologin/tst-pam_nologin-retval.c
> @@ -12,6 +12,7 @@
> #include <unistd.h>
> #include <pwd.h>
> #include <security/pam_appl.h>
> +#include <pam_hurd_max_stub.h>
>
> #define MODULE_NAME "pam_nologin"
> #define TEST_NAME "tst-" MODULE_NAME "-retval"
> diff --git a/modules/pam_permit/tst-pam_permit-retval.c b/modules/pam_permit/tst-pam_permit-retval.c
> index aacdedba..a129bb82 100644
> --- a/modules/pam_permit/tst-pam_permit-retval.c
> +++ b/modules/pam_permit/tst-pam_permit-retval.c
> @@ -11,6 +11,7 @@
> #include <string.h>
> #include <unistd.h>
> #include <security/pam_appl.h>
> +#include <pam_hurd_max_stub.h>
>
> #define MODULE_NAME "pam_permit"
> #define TEST_NAME "tst-" MODULE_NAME "-retval"
> diff --git a/modules/pam_rootok/tst-pam_rootok-retval.c b/modules/pam_rootok/tst-pam_rootok-retval.c
> index 990ee126..bb05a195 100644
> --- a/modules/pam_rootok/tst-pam_rootok-retval.c
> +++ b/modules/pam_rootok/tst-pam_rootok-retval.c
> @@ -11,6 +11,7 @@
> #include <string.h>
> #include <unistd.h>
> #include <security/pam_appl.h>
> +#include <pam_hurd_max_stub.h>
>
> #define MODULE_NAME "pam_rootok"
> #define TEST_NAME "tst-" MODULE_NAME "-retval"
> diff --git a/modules/pam_warn/tst-pam_warn-retval.c b/modules/pam_warn/tst-pam_warn-retval.c
> index 48b1f311..83bf2aad 100644
> --- a/modules/pam_warn/tst-pam_warn-retval.c
> +++ b/modules/pam_warn/tst-pam_warn-retval.c
> @@ -11,6 +11,7 @@
> #include <string.h>
> #include <unistd.h>
> #include <security/pam_appl.h>
> +#include <pam_hurd_max_stub.h>
>
> #define MODULE_NAME "pam_warn"
> #define TEST_NAME "tst-" MODULE_NAME "-retval"
> diff --git a/modules/pam_xauth/pam_xauth.c b/modules/pam_xauth/pam_xauth.c
> index 5e80b312..6c70b3f7 100644
> --- a/modules/pam_xauth/pam_xauth.c
> +++ b/modules/pam_xauth/pam_xauth.c
> @@ -67,6 +67,10 @@
> #include "pam_cc_compat.h"
> #include "pam_inline.h"
>
> +#ifndef HOST_NAME_MAX
> +#define HOST_NAME_MAX 255
> +#endif
> +
> #define DATANAME "pam_xauth_cookie_file"
> #define XAUTHENV "XAUTHORITY"
> #define HOMEENV "HOME"
> diff --git a/tests/tst-dlopen.c b/tests/tst-dlopen.c
> index cba3e9a8..118091ad 100644
> --- a/tests/tst-dlopen.c
> +++ b/tests/tst-dlopen.c
> @@ -14,9 +14,7 @@
> #include <limits.h>
> #include <sys/stat.h>
>
> -#ifndef PATH_MAX
> -# define PATH_MAX 4096
> -#endif
> +#include <pam_hurd_max_stub.h>
>
> /* Simple program to see if dlopen() would succeed. */
> int main(int argc, char **argv)
> --
> Yuqian Yang <crupest@crupest.life>
>
--
Samuel
* c is away : cuisine; bouffe
<y> oh, moi je fais plutôt cuisine & bouffe en fait :)
<c> oui c'est vrai, certains font cuisine && bouffe (juste au cas où... ;-))
<y> ( cuisine && bouffe ) || restau
<N> voire ((cuisine && bouffe) || restau) & apéritif
-+- #ens-mim -+-
Reply to: