[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#946650: ktexteditor: FTBFS on hurd-i386: KateDocumentTest::testAutoReload fails



Source: ktexteditor
Severity: important
Version: 5.62.0-1
Tags: patch
User: debian-hurd@lists.debian.org
Usertags: hurd
X-Debbugs-CC: debian-hurd@lists.debian.org

Hello,

ktexteditor fails to build on hurd-i386 because of a failure of
testAutoReload in katedocument_test.

The test appears to be failing due to an insufficient wait times,
increasing the wait time resolved the issue.

Attached is a patch which increases the wait times from (200 + 800) ms
by 500 ms to (200 + 1300) ms.

Thanks!

Excerpt of build log [0]:
>       Start 46: katedocument_test
> 46/67 Test #46: katedocument_test
> .......................***Failed    3.21 sec
> FAIL!  : KateDocumentTest::testAutoReload() Compared values are not
> the same
>    Actual   (doc.text())   : "Hello"
>    Expected ("Hello\nTest"): Hello
> Test
>    Loc: [/<<PKGBUILDDIR>>/autotests/src/katedocument_test.cpp(667)]
> [...]
> Totals: 20 passed, 1 failed, 0 skipped, 0 blacklisted, 3080ms
> ********* Finished testing of KateDocumentTest *********

[0]: 
https://buildd.debian.org/status/fetch.php?pkg=ktexteditor&arch=hurd-i386&ver=5.62.0-1%2Bb2&stamp=1573945897&raw=0
Subject: Fix test failure on hurd-i386: Increase wait times
Author: Paul Sonnenschein <paul@sonnenschein.ruhr>

--- a/autotests/src/katedocument_test.cpp	2019-09-07 16:49:33.000000000 +0200
+++ b/autotests/src/katedocument_test.cpp	2019-12-12 20:36:20.000000000 +0100
@@ -663,7 +663,7 @@
 
      // Hardcoded delay m_modOnHdTimer in DocumentPrivate
     // + min val with which it looks working reliable here
-    QTest::qWait(200 + 800);
+    QTest::qWait(200 + 1300);
     QCOMPARE(doc.text(), "Hello\nTest");
     // ...stay in the last line after reload!
     QCOMPARE(view->cursorPosition().line(), doc.documentEnd().line());
@@ -676,7 +676,7 @@
     stream.flush();
     file.close();
 
-    QTest::qWait(200 + 800);
+    QTest::qWait(200 + 1300);
     QCOMPARE(doc.text(), "Hello\nTest\nWorld!");
     // ...and ensure we have not move around
     QCOMPARE(view->cursorPosition(), c);

Attachment: signature.asc
Description: This is a digitally signed message part


Reply to: