Re: hping3: fix for FTBFS

[Samuel Thibault <sthibault@debian.org>]

Hello,

Guillaume Delacour, le Wed 03 Sep 2014 14:13:07 +0200, a écrit :
> http://mentors.debian.net/debian/pool/main/h/hping3/hping3_3.a2.ds2-7.dsc

It looks good, except that script.c could rather easily be rewritten not
to use PATH_MAX instead of setting an arbitrary value, something like
(untested):

-		char rcfile[PATH_MAX];
-		snprintf(rcfile, PATH_MAX, "%s/.hpingrc", home);
-		rcfile[PATH_MAX-1] = '\0';
+		char *rcfile;
+		asprintf(&rcfile, PATH_MAX, "%s/.hpingrc", home);
		Tcl_EvalFile(interp, rcfile);
		Tcl_ResetResult(interp);
+		free(rcfile);

Samuel