Re: MAXPATHLEN in ncpfs
Thomas Danckaert, le Sat 07 Sep 2013 17:07:17 +0200, a écrit :
> ===================================================================
> --- ncpfs_fix.orig/include/ncp/ncplib.h 2013-09-07 15:12:30.000000000 +0200
> +++ ncpfs_fix/include/ncp/ncplib.h 2013-09-07 16:59:04.454074383 +0200
> @@ -393,7 +393,7 @@
> fixedCharArray server[NCP_BINDERY_NAME_LEN];
> char* user;
> uid_t uid;
> - fixedCharArray mount_point[MAXPATHLEN];
> + char* mount_point;
> };
> #else
> struct ncp_conn_ent
Ergl. This will have to be discussed with upstream: this is actually
both an API change and an ABI change.
I guess the API change will not be a too big issue: it is mostly about
sizeof(mount_point) not being the size of the array any more, but
usually this is fine because applications are not supposed to do it
anyway.
The ABI change, however, will require a soname bump: at the binary
level, char[] and char* are completely different, and thus applications
have to be recompiled, and thus a soname bump is required to assert
that.
Samuel
Reply to: