[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: memstat-0.9 hurd patch (PATH_MAX)



2012/1/24 Tanguy LE CARROUR <tanguy.lecarrour@gmail.com>:
> I applied the unconditional realloc()...
> ... I also check the return value of malloc():

Okay, good.

One last minor thing:
+	buf_size = buf_size ? buf_size * 2 : BUFSIZ + 1;

The "+ 1" is not necessary (consider BUFSIZ could be any value).

Otherwise, the patch is great, you should submit a bug report.

-- 
Jérémie Koenig <jk@jk.fr.eu.org>
http://jk.fr.eu.org/


Reply to: