[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Bug#578320: dot fails with assertion on hurd-i386



tags 578320 + patch
thanks

Hello,

Samuel Thibault, le Mon 19 Apr 2010 22:23:27 +0200, a écrit :
> > > One workaround is to link the application itself with -pthread, but we
> > > really need to fix it more generally, as quite a few packages have the
> > > same issue.

That'll however not be within any short term.

> > Well graphviz certainly does dlopen plugins, but AFAICT everything gets
> > compiled and linked with -pthread already.
> 
> Not the programs themselves, for instance:
> 
> /bin/bash ../../libtool --tag=CC   --mode=link i486-gnu-gcc  -g -O2 -Wno-unknown-pragmas -Wstrict-prototypes -Wpointer-arith -Wall -ffast-math  -Wl,--as-needed -o dot dot-dot.o dot-no_builtins.o ../../lib/gvc/libgvc.la -ldl

Could you apply the attached patch to force adding -lpthread? (Yes, it
needs to be passed with -Wl, else libtool reorders it.

Samuel
--- debian/rules.original	2011-03-07 22:31:58.000000000 +0000
+++ debian/rules	2011-03-08 01:50:33.000000000 +0000
@@ -11,6 +11,11 @@
 # Get build platform info
 export DEB_HOST_GNU_TYPE  ?= $(shell dpkg-architecture -qDEB_HOST_GNU_TYPE)
 export DEB_BUILD_GNU_TYPE ?= $(shell dpkg-architecture -qDEB_BUILD_GNU_TYPE)
+export DEB_HOST_ARCH_OS   ?= $(shell dpkg-architecture -qDEB_HOST_ARCH_OS)
+
+ifeq ($(DEB_HOST_ARCH_OS),hurd)
+CONFIGURE_LIBS    = LIBS="-Wl,--no-as-needed -Wl,-lpthread -Wl,--as-needed"
+endif
 
 UPSTREAM_VERSION  = $(shell dpkg-parsechangelog | perl -ne 'print $$1 if /^Version: (.*?)-(.*)$$/')
 # SONAME version for libgvc and libcgraph 
@@ -71,6 +76,7 @@
 	--disable-r \
 	--disable-sharp \
 	$(shell echo $(PYTHON_VERSIONS) | sed -e's,python,--enable-python,g' -e 's,\.,,g') \
+	$(CONFIGURE_LIBS) \
 	LDFLAGS="-Wl,--as-needed"
 	touch configure-stamp
 

Reply to: