[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

[debian-hurd-Patches][311015] procps-3.2.7 patch

Patches item #311015, was opened at 21/08/2008 14:38
Status: Open
Priority: 3
Submitted By: Madhusudan C.S (madhusudancs-guest)
Assigned to: Nobody (None)
Summary: procps-3.2.7 patch 
Category: None
Group: None
Resolution: None

Initial Comment:
This patch eliminates the PATH_MAX problem in files ./proc/readproc.c and ./pwd.x.

Also alternatives method is used not to override the tools that are common in Hurd and procps.


>Comment By: Samuel Thibault (sthibaul-guest)
Date: 21/08/2008 17:54

Also, why removing tload?  Shouldn't it work?  You should probably also
discuss with kfreebsd people whether removing pmap, slabtop there too
(that code should probably be shared)


Comment By: Madhusudan C.S (madhusudancs-guest)
Date: 21/08/2008 17:48

This is the second patch and I think this should be applied, since this adds few additional tools that should not be installed on Hurd.


Comment By: Samuel Thibault (sthibaul-guest)
Date: 21/08/2008 17:46

By definition, sizeof(char) is 1.

for the buf allocation, can't you just use 6 + strlen(argv[i]) + 4 + 1 ?

Instead of using strlen(pathbuf), just remember the size you allocated
last time.

Take care of spurious spacing changes, always read the patch itself to
check for those.


You can respond by visiting: 

Reply to: