[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

[debian-hurd-Patches][311015] procps-3.2.7 patch



Patches item #311015, was opened at 2008-08-21 18:08
Status: Open
Priority: 3
Submitted By: Madhusudan C.S (madhusudancs-guest)
Assigned to: Nobody (None)
Summary: procps-3.2.7 patch 
Category: None
Group: None
Resolution: None


Initial Comment:
This patch eliminates the PATH_MAX problem in files ./proc/readproc.c and ./pwd.x.

Also alternatives method is used not to override the tools that are common in Hurd and procps.



----------------------------------------------------------------------

>Comment By: Madhusudan C.S (madhusudancs-guest)
Date: 2008-08-21 21:18

Message:
This is the second patch and I think this should be applied, since this adds few additional tools that should not be installed on Hurd.

----------------------------------------------------------------------

Comment By: Samuel Thibault (sthibaul-guest)
Date: 2008-08-21 21:16

Message:
By definition, sizeof(char) is 1.

for the buf allocation, can't you just use 6 + strlen(argv[i]) + 4 + 1 ?

Instead of using strlen(pathbuf), just remember the size you allocated
last time.

Take care of spurious spacing changes, always read the patch itself to
check for those.


----------------------------------------------------------------------

You can respond by visiting: 
http://alioth.debian.org/tracker/?func=detail&atid=410472&aid=311015&group_id=30628


Reply to: