Re: patch to parted-1.7.1

[Samuel Thibault <samuel.thibault@ens-lyon.org>]

Madhusudan C.S, le Mon 26 May 2008 09:54:40 +0530, a écrit :
> Is it ok if I manipulate this part of the s390.dpatch as given below. Or should
> I have to apply the dpatch to the code, make necessary changes in configure.ac
> to include AM_CONDITIONAL, make changes in libparted/labels/Makefile.am and
> generate dpatch again?

I'd rather use an AM_CONDITIONAL, but maybe upstream will be fine with
the code below, so I'd say you can file a bug to see what they think of
it.

> @@ -20,7 +20,11 @@
>              loop.c         \
>              mac.c          \
>              pc98.c         \
> -            sun.c
> +                       if test "$OS" = gnu; then
> +                       else
> +                            sun.c         \
> +                            s390.c
> +                       fi
> 

Doesn't test "$OS" != gnu work?
Also, you shouldn't disable sun.c.

Samuel