Hello! On Wed, Apr 11, 2007 at 09:21:21AM -0700, Thomas Bushnell BSG wrote: > No, you should spend your time on the Hurd, because there are fewer > people that can do that work. Keep track of programs that have PATH_MAX > or access(NULL) problems, and when people say, "how can I help", we can > point them at this list. > > File Debian bug reports on the Debian packages concerned. Let the > Debian maintainers cope with dealing with upstream (after all, it's what > they have volunteered for). As both these two paragraphs didn't work out as described, I went ahead and decided to do the work myself... The patches are submitted to the git mailing list, the ``access (NULL, m)'' one already got applied, the trivial `Makefile' one not yet, but I think that's just because the maintainer missed it in all those hundreds of emails rushing through that mailing list. I'll resubmit that one somewhen later. Michael, again, please apply these two attached patches to the Debian `git' package, build and upload. You did say that the Debian git build system does not run the included git test suite, right? Because running that one may still do harm to the ext2fs file system translator which is serving the build directory. (See <http://lists.gnu.org/archive/html/bug-hurd/2007-05/msg00002.html> for my original report about that problem.) Regards, Thomas
From 0928db307e75b30b1ba75d36eb37539cd09cd32d Mon Sep 17 00:00:00 2001 From: Thomas Schwinge <tschwinge@gnu.org> Date: Sat, 28 Jul 2007 17:51:27 +0200 Subject: [PATCH] Support building on GNU/Hurd GNU/Hurd systems don't have strlcpy either. Signed-off-by: Thomas Schwinge <tschwinge@gnu.org> --- Makefile | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/Makefile b/Makefile index 73b487f..682892f 100644 --- a/Makefile +++ b/Makefile @@ -456,6 +456,10 @@ ifeq ($(uname_S),AIX) NO_STRLCPY = YesPlease NEEDS_LIBICONV=YesPlease endif +ifeq ($(uname_S),GNU) + # GNU/Hurd + NO_STRLCPY=YesPlease +endif ifeq ($(uname_S),IRIX64) NO_IPV6=YesPlease NO_SETENV=YesPlease -- 1.5.3.rc3.26.g6c58-dirty
From 8b4aee015e2d81dc6cc53328aedc66742a5306d8 Mon Sep 17 00:00:00 2001
From: Thomas Schwinge <tschwinge@gnu.org>
Date: Sat, 28 Jul 2007 20:26:35 +0200
Subject: [PATCH] Don't rely on unspecified behavior
Calling access(p, m) with p == NULL is not specified, so don't do that. On
GNU/Hurd systems doing so will result in a SIGSEGV.
Signed-off-by: Thomas Schwinge <tschwinge@gnu.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
builtin-add.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/builtin-add.c b/builtin-add.c
index 7345479..de5c108 100644
--- a/builtin-add.c
+++ b/builtin-add.c
@@ -60,7 +60,7 @@ static void fill_directory(struct dir_struct *dir, const char **pathspec,
path = git_path("info/exclude");
if (!access(path, R_OK))
add_excludes_from_file(dir, path);
- if (!access(excludes_file, R_OK))
+ if (excludes_file != NULL && !access(excludes_file, R_OK))
add_excludes_from_file(dir, excludes_file);
}
--
1.5.3.rc3.96.g70cd
Attachment:
signature.asc
Description: Digital signature