Bug#185094: marked as done (Patch consider_lmm_collect: Test always true)
Your message dated Thu, 12 Jan 2006 00:58:58 +0200
with message-id <20060111225858.GC17640@zulo.hadrons.org>
and subject line #185094: Patch consider_lmm_collect: Test always true
has caused the attached Bug report to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere. Please contact me immediately.)
Debian bug tracking system administrator
(administrator, Debian Bugs database)
--------------------------------------
Received: (at submit) by bugs.debian.org; 17 Mar 2003 00:26:58 +0000
>From jtobey@john-edwin-tobey.org Sun Mar 16 18:26:57 2003
Return-path: <jtobey@john-edwin-tobey.org>
Received: from dsl092-070-217.bos1.dsl.speakeasy.net (feynman.localnet) [66.92.70.217]
by master.debian.org with esmtp (Exim 3.12 1 (Debian))
id 18uiSu-0004GY-00; Sun, 16 Mar 2003 18:26:56 -0600
Received: from jtobey by feynman.localnet with local (Exim 3.35 #1 (Debian))
id 18uieq-0005e1-00; Sun, 16 Mar 2003 19:39:16 -0500
Date: Sun, 16 Mar 2003 19:39:16 -0500
From: John Tobey <jtobey@john-edwin-tobey.org>
To: submit@bugs.debian.org
Subject: Patch consider_lmm_collect: Test always true
Message-ID: <20030317003916.GA21674@john-edwin-tobey.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.3.28i
Delivered-To: submit@bugs.debian.org
X-Spam-Status: No, hits=-2.8 required=4.0
tests=HAS_PACKAGE,PATCH_UNIFIED_DIFF,SPAM_PHRASE_00_01,
USER_AGENT,USER_AGENT_MUTT
version=2.44
X-Spam-Level:
Package: gnumach
Version: CVS 20030316
In gnumach/oskit/osenv_mem.c, consider_lmm_collect() looks as if it
can stop short of transfering the optimal number of pages from VM to
LMM due to an oversight. The variable `i' is decremented to 0 before
it is compared to `batch'. Since `batch' is always positive there,
the test will always come out true, and the loop will exit too early.
The following patch should fix this.
-John
Index: oskit/osenv_mem.c
===================================================================
RCS file: /cvsroot/hurd/gnumach/oskit/osenv_mem.c,v
retrieving revision 1.2
diff -u -r1.2 osenv_mem.c
--- oskit/osenv_mem.c 27 May 2002 23:01:57 -0000 1.2
+++ oskit/osenv_mem.c 16 Mar 2003 23:47:40 -0000
@@ -402,10 +402,11 @@
unsigned int batch = need > PAGE_BATCH ? PAGE_BATCH : need;
void *pages[PAGE_BATCH];
unsigned int i;
+ vm_page_t mem = VM_PAGE_NULL;
for (i = 0; i < batch; ++i)
{
- vm_page_t mem = vm_page_grab (FALSE);
+ mem = vm_page_grab (FALSE);
if (mem == VM_PAGE_NULL)
break;
pages[i] = (void *) mem->phys_addr;
@@ -424,7 +425,7 @@
simple_unlock (&phys_lmm_lock);
splx (s);
- if (i < batch)
+ if (mem == VM_PAGE_NULL)
break;
need -= batch;
}
---------------------------------------
Received: (at 185094-done) by bugs.debian.org; 11 Jan 2006 22:58:52 +0000
>From guillem@master.debian.org Wed Jan 11 14:58:52 2006
Return-path: <guillem@master.debian.org>
Received: from master.debian.org ([146.82.138.7])
by spohr.debian.org with esmtp (Exim 4.50)
id 1Ewovc-0003YZ-2M
for 185094-done@bugs.debian.org; Wed, 11 Jan 2006 14:58:52 -0800
Received: from guillem by master.debian.org with local (Exim 4.50)
id 1Ewovb-0006iV-87
for 185094-done@bugs.debian.org; Wed, 11 Jan 2006 16:58:51 -0600
Date: Thu, 12 Jan 2006 00:58:58 +0200
From: Guillem Jover <guillem@debian.org>
To: 185094-done@bugs.debian.org
Subject: #185094: Patch consider_lmm_collect: Test always true
Message-ID: <20060111225858.GC17640@zulo.hadrons.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.5.11
Sender: Guillem Jover <guillem@master.debian.org>
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02
(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Level:
X-Spam-Status: No, hits=-3.0 required=4.0 tests=BAYES_00 autolearn=no
version=2.60-bugs.debian.org_2005_01_02
Hi,
This problem affects oskit-mach, which is not packaged for Debian
currently. And as the patch has been forwarded upstream now, I'm
closing this bug.
thanks,
guillem
Reply to: