[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: tcpdump-3.8.3



On Thu, Feb 10, 2005 at 08:57:06PM -0800, Barry deFreese wrote:
> --- tcpdump-stdinc.horg 2005-02-10 18:33:19.000000000 -0500
> +++ tcpdump-stdinc.h    2005-02-10 18:32:40.000000000 -0500
> @@ -42,6 +42,10 @@
> #ifndef tcpdump_stdinc_h
> #define tcpdump_stdinc_h
> 
> +#if defined(__GNU__)
> +# define MAXHOSTNAMELEN 64
> +#endif
> +
> #ifdef WIN32
> 
> #include <stdio.h>

It's better to just do

#ifndef MAXHOSTNAMELEN
#define MAXHOSTNAMELEN 4096
#endif

no need to specify __GNU__ explicitely, as this is not really Hurd
specific (other than that we happen to not have it installed).

> Normally I wouldn't do that for MAXHOSTNAMELEN issues but they already 
> had a section for #ifdef (WIN32) #define MAXHOSTNAMELEN 64 so I figured wtf.

Well, I guess you could combine the two, or just modify the (WIN32) one
as mentioned above. 


cheers,

Michael

-- 
Michael Banck
Debian Developer
mbanck@debian.org
http://www.advogato.org/person/mbanck/diary.html



Reply to: