Re: acl: FTBFS on GNU/Hurd
On Sat, Oct 11, 2003 at 05:49:08PM +0000, Robert Millan wrote:
> Fixed now. Someone should bang upstream with a large trout over this ;)
This is a typical porting problem, but you should be trouted for not having
this figured out before making the bug report ;)
> [...]
> -ifeq ($(PKG_PLATFORM),linux)
> +ifeq ($(PKG_LIBC),gnu)
> PCFLAGS = -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64
> endif
> [...]
> +
> + case `uname -s` in Linux|GNU|GNU/*) pkg_libc=gnu ;; esac
> + test -z "$LIBC" || pkg_libc="$LIBC"
> + AC_SUBST(pkg_libc)
This check is just dumb. It can be done slightly better with this check
from the gettext package: /usr/share/aclocal/glibc21.m4
However, this is still suboptimal. Why not just use these:
AC_GNU_SOURCE
AC_SYS_LARGEFILE
I will never understand why people make things so artificially complicated ;)
Thanks,
Marcus
--
`Rhubarb is no Egyptian god.' GNU http://www.gnu.org marcus@gnu.org
Marcus Brinkmann The Hurd http://www.gnu.org/software/hurd/
Marcus.Brinkmann@ruhr-uni-bochum.de
http://www.marcus-brinkmann.de/
Reply to: