[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Condor Upload



Hello Andreas,

Thank you for all the work.

So, in the build/packaging/new-debian directory (soon to be renamed debian) you will find the build files that we use the build the packages on our build system. In an ideal world, there files would be identical with the exception of a slight change in version string.

I agree that it is important to fix up what is easy right now and ensure good copyright file. I can come back and make further fixes. Anything that you find and patch, I will apply upstream.

I see one major issue with your changes so far. A merge commit removed src/openstack_gahp and its sub directories. One of the sub-directories of the openstack_gahp is the rapidjson parser source. We compile out of our source tree, because the latest released version of rapidjson (1.1.0) has many bugs fixed in their github repository, but they have not made an official release. So, we need to use the rapidjson sources in our source tree. This change came in on a merge commit and undoing bad merges is always tricky business. How would you like to proceed?

We could release without the openstack_gahp. However, our local copy of the rapidjson source is needed for the multifile curl plugin, which is an essential part of HTCondor.

I could just put the source back. The history would not be correct in the master branch. However, the upstream branch would have the proper history.

...Tim

On 10/28/22 07:02, Andreas Tille wrote:
Hi Tim,

Am Thu, Oct 27, 2022 at 11:31:02AM -0500 schrieb Tim Theisen:
Thank you for the help.
You are welcome.  Please note: I'm not a user of condor.  My main
motivation is that the Debian Med team took over responsibility of
Neurodebian packages and I failed for years to sort this out.  So I'll
probably leave you alone once the package is maintained (and thus
uploaded with the proper maintainer address and VCS fields) of Debian
HPC Team (I just fixed the Maintainer address).

These are important metadata which influence several workflows which
are broken for years now.  Just to make sure you will understand my
motivation correctly.

To stress that I'm for the moment highly motivated I fixed quite some
lintian issues which you can see in Salsa CI[1].  I see room for fixing
some more which might be easier for me than for you given that I have
quite some training with such issues.  But this will not happen before
next Tuesday (Monday is holiday here at my place).

I will work on this next week when I get back to the
office on Monday.
I would like you to decide one pretty important thing:  Please
reconsider the creation of the new binary package **temporarily**.  The
point is:  The current condor package is urgently needed at the earliest
point in time given it fixes so many CVEs and bugs.  When adding a new
binary package it takes an unpredictable time to pass the new queue and
my gut feeling tells me that we need to expect several months and most
probably several cycles in new.  This means the next stable release
would be (again) without condor.

To avoid this my suggestion is to either not ship the files in the new
binary package or leave them inside the main package, upload, wait until
the package is migrated to testing and add the new binary package
*later*.
I will check over your changes. Thank you for enabling Salsa CI. I've not
used it yet. I think it will be very useful for my updates. I tried running
lintian in my debian:sid Docker container and it just hung.
Strange, but anyway we have some solution now.
I intend that the upstream HTCSS Debian build files match the Debian build
files very closely. Just the version string should be different to
distinguish between them.
What are "the upstream HTCSS Debian build files"?

I know that the Debian build files need some work. They have been essential
untouched since Debian 9 (stretch).  For instance, we should be using the
debhelper stuff for systemd files.
Definitely.  Unfortunately I have not dealt with systemd yet.  Thus I
left this untouched.  May be its a good idea if you would concentrate on
this (seeking for examples at https://codesearch.debian.net or ask for
some help on debian-mentors@lists.debian.org is highly recommended).
I have many copyright updates from the HTCSS project. I will incorporate
those from upstream.
It makes sense to update this inside the Debian packaging but as I said
above:  For the moment I'd recommend to avoid some ftpmaster copyright
review since it takes more time than we have.

Hope this helps and have a nice weekend
      Andreas.

[1] https://salsa.debian.org/hpc-team/condor/-/jobs/3437307

--
Tim Theisen (he, him, his)
Release Manager
HTCondor & Open Science Grid
Center for High Throughput Computing
Department of Computer Sciences
University of Wisconsin - Madison
4261 Computer Sciences and Statistics
1210 W Dayton St
Madison, WI 53706-1685
+1 608 265 5736


Reply to: