[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: gitit post-update hook issue



Hi,

> Yes. I wrote email about post-update issue, which is serious.

ah, right. I saw that mail, and now I found it again.

Am Dienstag, den 19.01.2016, 01:52 +0000 schrieb Dmitry Bogatov:
> Here is commented typescript:
> 
> 	Script started on Tue 19 Jan 2016 04:25:41 AM MSK
> 	$ pwd
> 	/tmp/foo
> 	$ ls
> 	typescript
> 	$ gitit
> 	gitit: /usr/share/filestore/extra/post-update: openBinaryFile: does not exist (No such file or directory)
> 	$ ls
> 	wikidata/  gitit.log  typescript
> 	$ ls wikidata
> 	.git
> 	$ # no front-page!!
> 	$ gitit
> 	Created static/css/custom.css
> 	Created static/img/logo.png
> 	Created templates/footer.st
> 	^C
> 	$ ls wikidataa
> 	.git
> 	$ # still no front page!!
> 
> 	Script done on Tue 19 Jan 2016 04:26:49 AM MSK
> 
> So problem is failure to invoke post-update hook aborts process, which
> also initialize front page. Nothing stops user from initializing it
> herself, via web interface or git, though. Problem is that I fail to
> locate code where post-update hook is invoked from. I will keep digging,
> but if you see more then me, help is welcome.

post-update is likely simply called by git. It is installed by
haskell-filestore (note the filestore in the path in the error
message!); filestore has this code:

       -- Add the post-update hook, so that changes made remotely via git
       -- will be reflected in the working directory.
       postupdatepath <- getDataFileName $ "extra" </> "post-update"
       postupdatecontents <- B.readFile postupdatepath
       let postupdate = repo </> ".git" </> "hooks" </> "post-update"
       B.writeFile postupdate postupdatecontents
       perms <- getPermissions postupdate
       setPermissions postupdate (perms {executable = True})

The script is in libghc-filestore-data, but there is no dependency from
gitit to filestore-data, it seems.

Does it work for you if you install libghc-filestore-data?

Note that libghc-filestore-dev does ship this file
$ cat /usr/lib/haskell-packages/extra-packages/filestore-0.6.0.6
libghc-filestore-data (>= 0.6.0.6)
so in theory, this dependency should be automatically added to gitit
via 
Depends: ${haskell:Extra-Depends},

Might be a bug in dh_haskell_extra_depends, did not look further.

Does this unblock you?

Greetings,
Joachim

-- 
Joachim "nomeata" Breitner
Debian Developer
  nomeata@debian.org | ICQ# 74513189 | GPG-Keyid: F0FBF51F
  JID: nomeata@joachim-breitner.de | http://people.debian.org/~nomeata

Attachment: signature.asc
Description: This is a digitally signed message part


Reply to: