Hi David, Am Donnerstag, den 20.08.2015, 16:38 -0700 schrieb David Fox: > I've just uploaded 4.31.2 which fixes the test suite. There were > files missing from the cabal package and the test data needed > updating, along with one or two other tweaks. > Thanks! But does the test suite actually report errors properly, i.e. set the return code? If I run "cabal test", I get mentions of Failures, but still cabal believes the test was successful: $ cabal test --show-detail=streaming Preprocessing library cabal-debian-4.31.2... In-place registering cabal-debian-4.31.2... Preprocessing test suite 'cabal-debian-tests' for cabal-debian-4.31.2... Running 1 test suites... Test suite cabal-debian-tests: RUNNING... ### Failure in: Debianization Tests:1:test5 - test-data/creativeprompts test5 - test-data/creativeprompts expected: "" but got: "Modified: \"debian/control\"\n--- old/debian/control\n+++ new/debian/control\n@@\n libghc-mtl-dev,\n libghc-network-dev,\n- libghc-old-locale-dev,\n- libghc-old-time-dev,\n@@\n libghc-parsec3-dev (>= 3) | libghc-parsec2-dev (<< 3),\n libghc-random-dev,\n" ### Failure in: Debianization Tests:2:test6 - test-data/artvaluereport2 test6 - test-data/artvaluereport2 expected: (ExitSuccess,"","") but got: (ExitSuccess,"--- old/debian/control\n+++ new/debian/control\n@@\n libghc-mtl-dev,\n libghc-network-dev (>= 2.4),\n- libghc-old-locale-dev,\n- libghc-old-time-dev,\n@@\n libghc-pandoc-dev,\n libghc-parsec3-dev,\n","") ### Failure in: Debianization Tests:4:test8 - test-data/artvaluereport-data test8 - test-data/artvaluereport-data expected: "" but got: "Modified: \"debian/control\"\n--- old/debian/control\n+++ new/debian/control\n@@\n libghc-network-dev (>= 2.4),\n libghc-network-prof (>= 2.4),\n- libghc-old-time-dev,\n- libghc-old-time-prof,\n@@\n libghc-pandoc-dev,\n libghc-pandoc-prof,\n@@\n libghc-mtl-doc,\n libghc-network-doc,\n- libghc-old-time-doc,\n@@\n libghc-pandoc-doc,\n libghc-pandoc-types-doc,\n" Cases: 7 Tried: 7 Errors: 0 Failures: 3 Counts {cases = 7, tried = 7, errors = 0, failures = 3} Test suite cabal-debian-tests: PASS Test suite logged to: dist/test/cabal-debian-4.31.2-cabal-debian-tests.log 1 of 1 test suites (1 of 1 test cases) passed. Also, the diff is not very readable :-) Greetings, Joachim -- Joachim "nomeata" Breitner Debian Developer nomeata@debian.org | ICQ# 74513189 | GPG-Keyid: F0FBF51F JID: nomeata@joachim-breitner.de | http://people.debian.org/~nomeata
Attachment:
signature.asc
Description: This is a digitally signed message part