Hi,
Am Donnerstag, den 25.12.2014, 07:59 +0000 schrieb Dmitry Bogatov:
> I just joined team and uploaded bool-extras package. It is needed as
> dependency on blog-literately program, which I will upload a bit
> later. More information on ITP bugs.
great!
> Please, review.
Looks good mostly. Some issues that you still can improve:
* The package needs an Uploaders field, listing you.
* Priority: optional is too high. Use extra!
* The Vcs-* fields should refer to the VCS of the packaging. Have a
look at the "template-debian/" directory in our tools repository:
http://anonscm.debian.org/gitweb/?p=pkg-haskell/tools.git;a=tree;f=template-debian
* I generally doubt that the debian/ directory of a Haskell package is
copyrightable; IMHO it contains no original work. Therefore I find it
quite pointless to mention it in copyright, but that’s how people want
it. But licensing it differently than the package itself calls for
nothing but (if anything) trouble, so please change the copyright.
Again, the template is a good starting point, or alternative use
Files: debian/*
Copyright: held by the contributors mentioned in
debian/changelog
License: foo license
which does not require mentioning specific developers.
* Your debian/watch file is out of date. Again, look at the template.
Thanks, and happy christmas!
Joachim
--
Joachim "nomeata" Breitner
Debian Developer
nomeata@debian.org | ICQ# 74513189 | GPG-Keyid: F0FBF51F
JID: nomeata@joachim-breitner.de | http://people.debian.org/~nomeata
Attachment:
signature.asc
Description: This is a digitally signed message part