[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Bug#751785: ITP: haskell-shake -- build system library, like Make, but more accurate dependencies



Hi,

Am Freitag, den 27.06.2014, 12:59 +0100 schrieb Colin Watson:
> On Mon, Jun 16, 2014 at 01:39:39PM -0700, Joachim Breitner wrote:
> > Am Montag, den 16.06.2014, 17:22 +0100 schrieb Colin Watson:
> > > (This has been in the Haskell team's package plan for a while; I'm
> > > packaging it now because the current version of haskell-hoogle became
> > > unbuildable following the transition to haskell-conduit 1.1, and newer
> > > upstream versions of haskell-hoogle require shake.)
> > 
> > I worked on it a bit but got stuck with javascript file issues. Upstream
> > added a hack that it works without the problematic viz.js, but I’m not
> > sure if that has been released yet:
> > https://github.com/ndmitchell/shake/issues/100
> 
> This should all be sorted now (albeit not very gracefully;
> debian/patches/disable-viz.patch is pretty ugly).  Would you mind
> reviewing darcs.debian.org:/darcs/pkg-haskell/haskell-shake? 

the problem is that patching it out is not enough. According to the
general interpretaion, Debian must not distribute the file. So we need
to remove it from the tarball.

Theoretically, this would works quite nicely this way: With

        $ head copyright 
        Format: http://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
        Upstream-Name: shake
        Upstream-Contact: Neil Mitchell <ndmitchell@gmail.com>
        Source: http://hackage.haskell.org/package/shake
        # Disable viz.js; it's hard to provide source for this
        # see https://github.com/ndmitchell/shake/issues/100
        # and https://github.com/ndmitchell/shake/commit/3613e6
        Files-Excluded: html/viz.js
        
uscan would automatically repack the original tarball to not have that
file. Unfortunately, https://bugs.debian.org/748244 prevents that from
working. But that just means that we don’t get tool support in creating
the .orig.tar.gz and have to do that step manually. Therefore, I pushed
the change.

If I understand your packaging correctly, you are also not using the
embedded jquery and flot files, right? In that case it might actually be
easier to remove them as well (and simplify debian/copyright).

It is also custom to change the version to 0.13.1+dfsg1-1. 


Unrelated: How useful is the stand-alone shake tool? Is it worth having
it in a module of its own?


Greetings,
Joachim


-- 
Joachim "nomeata" Breitner
Debian Developer
  nomeata@debian.org | ICQ# 74513189 | GPG-Keyid: F0FBF51F
  JID: nomeata@joachim-breitner.de | http://people.debian.org/~nomeata

Attachment: signature.asc
Description: This is a digitally signed message part


Reply to: