[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: haskell-qt



Hi Filip,

Am Montag, den 06.06.2011, 17:04 +0200 schrieb Joachim Breitner:
> It’s still building and I’m about to leave, so more review possibly
> later.

another issue: libghc-qt-dev depends on libhaskell-qt, but without any
constraints. This maybe calls for trouble, e.g. when a use upgrades
libhaskell-qt, but not libghc-*-dev, and the other way around.

Does the libhaskell-qt part offer a stable ABI, with a soname that is
bumped when the ABI changes?

Hmm, I see that you added the dependency manuall in debian/control, but
also look what dh_shlibdeps does:

$ cat debian/libghc-qt-dev.substvars|grep ^shlibs
shlibs:Depends=libc6 (>= 2.7), libffi5 (>= 3.0.4), libgl1-mesa-glx | libgl1, libglu1-mesa | libglu1, libgmp10, libhaskell-qt

So it actually detects that libghc-qt-dev needs libhaskell-qt and
installs the dependency. I suggest you remove the manual mention and
rely on dh_shlibdeps.

More on packaging a C library can be found here
http://www.netfort.gr.jp/~dancer/column/libpkg-guide/libpkg-guide.html
and I think this makes it clear why I avoid packaging C libraries
myself :-)

Greetings,
Joachim

-- 
Joachim "nomeata" Breitner
Debian Developer
  nomeata@debian.org | ICQ# 74513189 | GPG-Keyid: 4743206C
  JID: nomeata@joachim-breitner.de | http://people.debian.org/~nomeata

Attachment: signature.asc
Description: This is a digitally signed message part


Reply to: