[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [Fwd: ITP: libghc6-extensible-exceptions -- Extensible exceptions for the Glasgow Haskell Compiler]



Hi,

Am Donnerstag, den 26.02.2009, 13:32 -0300 schrieb Marco Túlio Gontijo e
Silva:
> Em Qui, 2009-02-26 às 16:15 +0100, Joachim Breitner escreveu:
> > Am Donnerstag, den 26.02.2009, 11:20 -0300 schrieb Marco Túlio Gontijo e
> > Silva:
> > > Assunto: ITP: libghc6-extensible-exceptions -- Extensible exceptions for
> > 
> > I have looked at this as well, and already stated packaging it, when I
> > noticed that all it does for ghc6.10 is re-exporting Control.Exception
> > as Control.Exception.Extensible.
> > 
> > So we do not need this package in Debian (where we only have one
> > compiler) and can just patch each package to use the other module name.
> 
> I don't like the idea of patching upstream source, unless it's really
> necessary.  In this case, I think it would harm less to have a silly
> package in the Debian context, than to have to patch the upstream
> version, and maintain the patches for each upstream release, of each
> package that depends on extensible-exceptions.

I just tried it: This simple patch makes it compile without that extra
library:

diff -ur terminfo-0.3.0.1/System/Console/Terminfo/Base.hs terminfo-0.3.0.1-my/System/Console/Terminfo/Base.hs
--- terminfo-0.3.0.1/System/Console/Terminfo/Base.hs	2009-02-06 21:45:04.000000000 +0100
+++ terminfo-0.3.0.1-my/System/Console/Terminfo/Base.hs	2009-02-26 19:26:21.000000000 +0100
@@ -46,7 +46,7 @@
 import System.Environment (getEnv)
 import System.IO.Unsafe (unsafePerformIO)
 import System.IO
-import Control.Exception.Extensible
+import Control.Exception
 import Data.Typeable
 
 
Nur in terminfo-0.3.0.1-my/System/Console/Terminfo: .Base.hs.swp.
diff -ur terminfo-0.3.0.1/terminfo.cabal terminfo-0.3.0.1-my/terminfo.cabal
--- terminfo-0.3.0.1/terminfo.cabal	2009-02-06 21:45:04.000000000 +0100
+++ terminfo-0.3.0.1-my/terminfo.cabal	2009-02-26 19:25:36.000000000 +0100
@@ -15,7 +15,7 @@
 Homepage:       http://code.haskell.org/terminfo
 Stability:      Experimental
 Build-type:     Configure
-Build-depends:  base>=1.0, extensible-exceptions>=0.1.1.0 && < 0.2
+Build-depends:  base>=1.0
 extra-source-files: configure.ac configure terminfo.buildinfo.in
 extra-tmp-files: config.log config.status autom4te.cache terminfo.buildinfo
 Extensions:     ForeignFunctionInterface, DeriveDataTypeable


While I generally agree that modifying upstream source should be
avoided, this patch is just too simple not to apply :-) And not having
another haskell package high in the dependency tree is a good thing,
IMHO.

I noticed that you use darcs to track your debian/ dir only. In case you
are not aware, you can use quilt or cdbs’s simple-patchsys to put your
changes there too.

Greetings,
Joachim
-- 
Joachim "nomeata" Breitner
Debian Developer
  nomeata@debian.org | ICQ# 74513189 | GPG-Keyid: 4743206C
  JID: nomeata@joachim-breitner.de | http://people.debian.org/~nomeata

Attachment: signature.asc
Description: Dies ist ein digital signierter Nachrichtenteil


Reply to: