Bug#987332: aprx automatically starts up with really bad default config

[Evgeni Golov <evgeni@debian.org>]

Hi,

On Thu, Apr 22, 2021 at 12:19:57AM +0300, Heikki Hannikainen wrote:
> - Have it not start up by default after installation, before it is configured

This should be doable by the following patch:
diff -Nru aprx-2.9.0+dfsg/debian/rules aprx-2.9.0+dfsg/debian/rules
--- aprx-2.9.0+dfsg/debian/rules	2018-09-27 03:20:51.000000000 +0000
+++ aprx-2.9.0+dfsg/debian/rules	2021-04-25 08:47:13.000000000 +0000
@@ -31,10 +31,13 @@
 	rm -vf ./test ./aprx-complex.conf Makefile

 override_dh_installinit:
-	dh_installinit --restart-after-upgrade
+	dh_installinit --restart-after-upgrade --no-enable

 override_dh_installdirs:
 	dh_installdirs
 	$(MAKE) DESTDIR=$(CURDIR)/debian/aprx logrotate.aprx install
 	cp logrotate.aprx debian/aprx.logrotate
 	install -m 644 apparmor.aprx $(CURDIR)/debian/aprx/etc/apparmor.d/sbin.aprx
+
+override_dh_installsystemd:
+	dh_installsystemd --no-enable


> - Remove N0CALL-1 from the default configuration (comment the line out) so
> that it will refuse to start up before configured with the callsign of the
> user

Is N0CALL-1 part of the default config aprx ships upstream?

> - Ensure that the instances which have already been started up like this
> will shut down again when upgraded to the next version

Not sure this is easily doable after the fact now, but we at least can
prevent new clients from poping up.