[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Comments regarding liquid-dsp_1.3.2-1_amd64.changes



On Wed, Dec 25, 2019 at 11:29:19PM +0100, Christoph Berg wrote:
> Heh, nice to see you on the other side of the table for that questio
> after you had already worked on it in the ham team. :)

I spent a lot of time looking at this one already, was easy enough to
review, since I was already doing review + not writing anything for it :)

> The soname bump is really necessary because some functions changed
> signature, https://github.com/jgaeddert/liquid-dsp/commit/22ccf5fb34a5a4253d984b2f1f81c67b7aa6eab7

Sounds good; as long as you thought about it and decidied in favor of
keeping it, that works for me!

> > We should bump the two r-deps and let release team know just as
> > a courtesy.
> 
> I've already cherry-picked the necessary bits for CubicSDR.

Perfect!

> And as for uncoordinated... that's what experimental is for...

I saw that after I pushed the prod (I prod'd then did the review), no
harm, no worries on that front, my mistake.

> 73 and thanks,
> Christoph

73s Christoph! Happy holidays!
  paultag

-- 
 .''`.  Paul Tagliamonte <paultag@debian.org>
: :'  : Proud Debian Developer
`. `'`  4096R / FEF2 EB20 16E6 A856 B98C E820 2DCD 6B5D E858 ADF3
 `-     http://people.debian.org/~paultag

Attachment: signature.asc
Description: PGP signature


Reply to: