Bug#888682: hamlib uses deprecated Tcl 8.5
Source: hamlib
Version: 3.1-7
Severity: important
Tags: patch
Dear Maintainer,
Since Tcl 8.5 has reached its end-of-life we are planning to remove
it from Debian before the buster's release. So please, switch the
libhamlib2-tcl package to a modern Tcl version which is 8.6 (or better
to a default one which should work for future 8.7 as well).
I've attached a proposed NMU which 1) replaces tcl8.5-dev by tcl-dev
in build dependencies and corrects the --with-tcl in debian/rules
(/usr/lib/tclConfig.sh includes a DEB_HOST_MULTIARCH hack, so don't bother
about deleting it from debian/rules configure call); 2) moves the
Tcl package to /usr/lib/tcltk/hamlib3.1 as it can be loaded to different
Tcl shells (I haven't tested it thoroughly). If you don't mind, I could do
the upload.
-- System Information:
Debian Release: 9.3
APT prefers stable-debug
APT policy: (500, 'stable-debug'), (500, 'proposed-updates'), (500, 'stable'), (500, 'oldstable'), (1, 'experimental'), (1, 'unstable'), (1, 'testing')
Architecture: amd64 (x86_64)
Foreign Architectures: i386
Kernel: Linux 4.14.0-0.bpo.3-amd64 (SMP w/12 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE=en_US:en (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
diff -Nru hamlib-3.1/debian/changelog hamlib-3.1/debian/changelog
--- hamlib-3.1/debian/changelog 2017-07-31 14:22:15.000000000 +0300
+++ hamlib-3.1/debian/changelog 2018-01-28 18:53:38.000000000 +0300
@@ -1,3 +1,14 @@
+hamlib (3.1-7.1) unstable; urgency=medium
+
+ * Non-maintainer upload.
+ * Switch to the default Tcl version from 8.5 since 8.5 is to be
+ removed from Debian.
+ * Move the Tcl library from /usr/lib/tcl8.5 to /usr/lib/tcltk/hamlib3.1
+ because it can be loaded into any available Tcl interpreter and not
+ just into 8.5.
+
+ -- Sergei Golovan <sgolovan@debian.org> Sun, 28 Jan 2018 18:53:38 +0300
+
hamlib (3.1-7) unstable; urgency=medium
* Team upload
diff -Nru hamlib-3.1/debian/control hamlib-3.1/debian/control
--- hamlib-3.1/debian/control 2017-07-31 14:22:15.000000000 +0300
+++ hamlib-3.1/debian/control 2018-01-19 14:31:51.000000000 +0300
@@ -3,7 +3,7 @@
Priority: optional
Maintainer: Debian Hamradio Maintainers <debian-hams@lists.debian.org>
Uploaders: Kamal Mostafa <kamal@whence.com>, Colin Tuckley <colint@debian.org>, Ervin Hegedus <airween@gmail.com>
-Build-Depends: debhelper (>= 9), pkg-config, doxygen, swig, libperl-dev, python-all-dev (>= 2.3.5-11), tcl8.5-dev, libusb-1.0-0-dev, dh-python, libltdl3-dev, zlib1g-dev, libgd-dev, dpkg-dev (>= 1.16.0), dh-autoreconf, dh-lua
+Build-Depends: debhelper (>= 9), pkg-config, doxygen, swig, libperl-dev, python-all-dev (>= 2.3.5-11), tcl-dev, libusb-1.0-0-dev, dh-python, libltdl3-dev, zlib1g-dev, libgd-dev, dpkg-dev (>= 1.16.0), dh-autoreconf, dh-lua
Build-Conflicts: hamlib-dev (<= 1.2.5-3)
Standards-Version: 4.0.0
XS-Python-Version: >= 2.4
diff -Nru hamlib-3.1/debian/libhamlib2-tcl.dirs hamlib-3.1/debian/libhamlib2-tcl.dirs
--- hamlib-3.1/debian/libhamlib2-tcl.dirs 2016-03-26 17:06:23.000000000 +0300
+++ hamlib-3.1/debian/libhamlib2-tcl.dirs 2018-01-28 18:53:38.000000000 +0300
@@ -1 +1,2 @@
+/usr/lib/tcltk/hamlib3.1
/usr/share/doc/libhamlib2-tcl
diff -Nru hamlib-3.1/debian/libhamlib2-tcl.install hamlib-3.1/debian/libhamlib2-tcl.install
--- hamlib-3.1/debian/libhamlib2-tcl.install 2017-07-03 15:52:24.000000000 +0300
+++ hamlib-3.1/debian/libhamlib2-tcl.install 2018-01-28 18:53:38.000000000 +0300
@@ -1,4 +1,4 @@
bindings/tcltest.tcl usr/share/doc/libhamlib2-tcl
-debian/tmp/usr/lib/tcl/Hamlib/hamlibtcl-3.1.so usr/lib/tcl8.5
-debian/tmp/usr/lib/tcl/Hamlib/hamlibtcl.so usr/lib/tcl8.5
-debian/tmp/usr/lib/tcl/Hamlib/pkgIndex.tcl usr/lib/tcl8.5
+debian/tmp/usr/lib/tcl/Hamlib/hamlibtcl-3.1.so usr/lib/tcltk/hamlib3.1
+debian/tmp/usr/lib/tcl/Hamlib/hamlibtcl.so usr/lib/tcltk/hamlib3.1
+debian/tmp/usr/lib/tcl/Hamlib/pkgIndex.tcl usr/lib/tcltk/hamlib3.1
diff -Nru hamlib-3.1/debian/rules hamlib-3.1/debian/rules
--- hamlib-3.1/debian/rules 2017-07-03 17:01:06.000000000 +0300
+++ hamlib-3.1/debian/rules 2018-01-19 14:34:02.000000000 +0300
@@ -30,7 +30,7 @@
--with-perl-binding \
--with-python-binding \
--with-tcl-binding \
- --with-tcl=/usr/lib/"$(DEB_HOST_MULTIARCH)"/tcl8.5 \
+ --with-tcl=/usr/lib \
--with-lua-binding
touch $@
make -f /usr/share/dh-lua/make/dh-lua.Makefile.multiple configure
Reply to: