[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#606338: marked as done (ax25ipd: fails to transmit packets with "assemble_kiss: dumped - control byte non-zero")



Your message dated Mon, 27 Feb 2012 03:17:13 +0000
with message-id <E1S1r5N-0001cK-4d@franck.debian.org>
and subject line Bug#606338: fixed in ax25-apps 0.0.8-rc2+cvs20120204-2
has caused the Debian Bug report #606338,
regarding ax25ipd: fails to transmit packets with "assemble_kiss: dumped - control byte non-zero"
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
606338: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=606338
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message ---
Package: ax25-apps
Version: 0.0.6-16.2
Severity: important
Tags: patch

Hi,

I was setting up ax25ipd last night, and it would receive data fine,
but wouldn't transmit anything out the IP side.  After looking in my
log files, I observed this message every time I tried to send a packet
out via ax25ipd:

Dec  7 17:49:56 hephaestus ax25ipd: assemble_kiss: dumped - control byte non-zero

I investigated, and found a check on the control byte in kiss.c.  I
studied the control bytes, and believe that they are used primarily to
select a port on multi-port TNCs.  I don't know why kissnetd or
kissattach cares about them, but there it is.

Now then, this is trivial to fix with the attached patch.  This is a
minimally-invasive one; a more proper upstream patch would remove the
whole test.  I have tested and it works beautifully.

-- System Information:
Debian Release: squeeze/sid
  APT prefers testing
  APT policy: (990, 'testing'), (500, 'unstable')
Architecture: amd64 (x86_64)

Kernel: Linux 2.6.32-5-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages ax25-apps depends on:
ii  debconf [debconf-2.0]  1.5.36            Debian configuration management sy
ii  libax25                0.0.11-6.1        ax25 library for hamradio applicat
ii  libc6                  2.11.2-6+squeeze1 Embedded GNU C Library: Shared lib
ii  libncurses5            5.7+20100313-4    shared libraries for terminal hand

ax25-apps recommends no packages.

Versions of packages ax25-apps suggests:
ii  ax25-tools                    0.0.8-13.1 tools for AX.25 interface configur

-- Configuration Files:
/etc/ax25/ax25ipd.conf changed [not included]

-- debconf information:
  ax25-apps/suid_listen: false
diff -durN ax25-apps-0.0.6/ax25ipd/kiss.c fixed/ax25-apps-0.0.6/ax25ipd/kiss.c
--- ax25-apps-0.0.6/ax25ipd/kiss.c	2001-10-08 20:03:12.000000000 -0500
+++ fixed/ax25-apps-0.0.6/ax25ipd/kiss.c	2010-12-07 18:35:19.444623640 -0600
@@ -72,7 +72,7 @@
 		if (c == FEND) {
 			if (ifcount > 0) {
 				/* Make sure that the control byte is zero */
-				if (*iframe == '\0' || *iframe == 0x10) {
+				if (1) {
 					/* Room for CRC in buffer? */
 					if (ifcount < (MAX_FRAME - 2)) {
 						stats.kiss_in++;

--- End Message ---
--- Begin Message ---
Source: ax25-apps
Source-Version: 0.0.8-rc2+cvs20120204-2

We believe that the bug you reported is fixed in the latest version of
ax25-apps, which is due to be installed in the Debian FTP archive:

ax25-apps_0.0.8-rc2+cvs20120204-2.diff.gz
  to main/a/ax25-apps/ax25-apps_0.0.8-rc2+cvs20120204-2.diff.gz
ax25-apps_0.0.8-rc2+cvs20120204-2.dsc
  to main/a/ax25-apps/ax25-apps_0.0.8-rc2+cvs20120204-2.dsc
ax25-apps_0.0.8-rc2+cvs20120204-2_amd64.deb
  to main/a/ax25-apps/ax25-apps_0.0.8-rc2+cvs20120204-2_amd64.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 606338@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Patrick Ouellette <pouelle@debian.org> (supplier of updated ax25-apps package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Sun, 26 Feb 2012 20:46:29 -0500
Source: ax25-apps
Binary: ax25-apps
Architecture: source amd64
Version: 0.0.8-rc2+cvs20120204-2
Distribution: unstable
Urgency: low
Maintainer: Debian Hamradio Maintainers <debian-hams@lists.debian.org>
Changed-By: Patrick Ouellette <pouelle@debian.org>
Description: 
 ax25-apps  - AX.25 ham radio applications
Closes: 510947 593666 606338 627843 659128
Changes: 
 ax25-apps (0.0.8-rc2+cvs20120204-2) unstable; urgency=low
 .
   * Fix "ax25ipd: fails to transmit packets with "assemble_kiss: dumped
     - control byte non-zero"" fixed in new upstream
     (Closes: #606338)
   * Fix pending l10n issues. Debconf translations:
   * Italian (Vincenzo Campanella).  Closes: #593666
   * Danish (Joe Hansen).  Closes: #627843
   * Polish (Michał Kułach).  Closes: #659128
   * Fix "Uses absolute path to call dpkg-statoverride" change check for
     - dpkg-statoverride from test to hash (Closes: #510947)
Checksums-Sha1: 
 64bff1c71f97f88f388a9a781b53e6ee9c2028dd 1357 ax25-apps_0.0.8-rc2+cvs20120204-2.dsc
 5989bafbdb36bdc2d5046008b53f2e56841d0034 342631 ax25-apps_0.0.8-rc2+cvs20120204-2.diff.gz
 066745bdb638bb790e5de2a76f83d621a56097e9 122988 ax25-apps_0.0.8-rc2+cvs20120204-2_amd64.deb
Checksums-Sha256: 
 47f7b25f7eef98aec81c232b0a1101d13d6d8395fabc2c9a5e1505fb048ef13e 1357 ax25-apps_0.0.8-rc2+cvs20120204-2.dsc
 9de31bf3473d0c92047db9f1aeb5000849f9826e8461e582652785f3aaa36cc1 342631 ax25-apps_0.0.8-rc2+cvs20120204-2.diff.gz
 994a5615dde5bbc826bd30566548e40d269d76f69186814ea09b05da00e53d37 122988 ax25-apps_0.0.8-rc2+cvs20120204-2_amd64.deb
Files: 
 d3c5b3f9f6c049b3134803a616d501e8 1357 hamradio extra ax25-apps_0.0.8-rc2+cvs20120204-2.dsc
 c9468923a46192cb85da460a5f85e0e5 342631 hamradio extra ax25-apps_0.0.8-rc2+cvs20120204-2.diff.gz
 a7a890ed9e910502a85913b66595badc 122988 hamradio extra ax25-apps_0.0.8-rc2+cvs20120204-2_amd64.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iEYEARECAAYFAk9K8lsACgkQz9qdgganN27DPQCgp/1a5OCECg8rOZ34R2AZUwQz
4nEAoMxH0JkHDqfN3SgUJrb8qfKCt67m
=eIJP
-----END PGP SIGNATURE-----



--- End Message ---

Reply to: