Bug#606338: ax25ipd transmission bug
On 12/08/2010 03:00 PM, Thomas Osterried wrote:
No. But you was the wone who suggestet the patch
"- if (*iframe == '\0' || *iframe == 0x10) {
+ if (1) {
"
After Ralf explained it, I'm in agreement with you that it's wrong.
which would lead ax25ipd to receive frames regardless of their kiss-port-tag (which would be wrong), and discussed later to let it receive at least frames with kiss-byte 0 ||>1.
Now you describe your setup where no multiport tnc is in use. Thus the whole discussion seems to be useless.
I don't think it is useless, because ax25ipd was refusing to transmit my
packets on IP, and I still believe it was because of this problem. I
have no idea why kissattach or kissnetd was setting those bits, or how
to control it.
I can say that whatever ax25ipd is sending back, kissattach finds fine.
So your& 0xf will solve my problem completely.
Whose& 0xf?
Pardon me, that was Ralf's in <[🔎] 20101208153841.GA31702@linux-mips.org>,
where he wrote:
| I'm just wondering why the test isn't (*iframe & 0xf) == 0 which would
| handle the full number of possible 16 possible TNCs.
So if you just take the "if (*iframe == '\0' || *iframe == 0x10) {" line
and replace it with "if ((*iframe & 0xf) == 0) {" it solves the bug and
causes no further damage.
-- John
Reply to: