[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: metacity-setup packages (0.7.1)



On Mon, 2002-09-02 at 13:44, Ian Wienand wrote:
> All,
> 
> I have updated my metacity-setup packages to reflect the latest
> version popping up in sourceforge (http://sourceforge.net/projects/metacity-setup/).
> 
> The story with this project appears to be that it will be useful
> untill about gnome-2.2, when redhat changes are merged into metacity
> and thus provide a way to switch themes and such without raw gconf editing.
> Seeing as there is some short to medium term future I would appreciate
> it if someone could hold my hand to help get the packages right, and
> sponsor them for inclusion.
> 
> The latest packages are available at http://www.wienand.org/debian/metacity-setup
> 

I'd be happy to sponsor this package into the archive for you:

Some points:

* debian/watch.ex is an example file left over from dh_make, you
probably dont want this.
* your manpage is buggy, "metacity-setup.1:23: a space character is not
alloewed in an escape name" you need to give proper sections and change
METACITY-SETUP to metacity-sectup. I'm not sure if you need to specify a
distribution license on your manpage.
* please use the correct format for name/email address in copyright it
should be <> not (). New line before "On Debian..."
* need a space after "Description:" in the control file
* when building i also had to update libglade2-0 it seems the
libglade2-dev package does not depend upon the correct version which
meant it couldnt link. a bug will be filed if one not already present
* you cant have a Reccomends: in the general section of the control
file, you should move this to the metacity-setup binary section.And it
should be Recommends
* you should do make distclean in your clean target or at least attempt
to, because repeat builds fail. you need to remove the tree and start
again fresh.
* you should strip the binary in the install section of the rules file
using dh_strip
* you have an extra space indentation in debian/control's long
description

Please fix these changes and let me know when you have an updated
release.

Cheers

Rob
-- 
Rob 'robster' Bradford

Attachment: signature.asc
Description: This is a digitally signed message part


Reply to: