Re: metacity-setup packages (0.7.1)

[Ian Wienand <ianw@ieee.org>]

On Tue, Sep 03, 2002 at 12:51:38PM +0100, Rob Bradford wrote:
> On Mon, 2002-09-02 at 13:44, Ian Wienand wrote:
> > 
> > The latest packages are available at http://www.wienand.org/debian/metacity-setup
> > 
> 
> I'd be happy to sponsor this package into the archive for you:

Thanks very much I appreciate it.

> * debian/watch.ex is an example file left over from dh_make, you
> probably dont want this.

Gone, it was out of date anyway.

> * your manpage is buggy, "metacity-setup.1:23: a space character is not
> alloewed in an escape name" you need to give proper sections and change
> METACITY-SETUP to metacity-sectup. I'm not sure if you need to specify a
> distribution license on your manpage.

Ok removed the space.  How did you get that message so you knew it was
buggy?  I changed the capitalisation and the section to 1.

> * please use the correct format for name/email address in copyright it
> should be <> not (). New line before "On Debian..."

Done.

> * need a space after "Description:" in the control file

I took it out because of this lintian message, but now i realise what
it really meanth was the *long* description : 

W: metacity-setup: description-starts-with-leading-spaces

but I'll put it back in.

> * when building i also had to update libglade2-0 it seems the
> libglade2-dev package does not depend upon the correct version which
> meant it couldnt link. a bug will be filed if one not already
> present

Ok

> * you cant have a Reccomends: in the general section of the control
> file, you should move this to the metacity-setup binary section.And it
> should be Recommends

After reading through the policy manual again, I think this should be
Suggests: anyway.  I have changed this.

> * you should do make distclean in your clean target or at least attempt
> to, because repeat builds fail. you need to remove the tree and start
> again fresh.

Ok I do a distclean now.  But it leaves behind
metacity-setup-0.7.1.tar.gz.  Should this be cleaned at the same time
too, because it caused dpkg-buildpackage to fail?

> * you should strip the binary in the install section of the rules file
> using dh_strip

ok added this

> * you have an extra space indentation in debian/control's long
> description

fixed

I've re-uploaded the fixed up debs to

http://www.wienand.org/debian/metacity-setup

Thanks,

-i
ianw@ieee.org
http://www.wienand.org