Re: salsa MR approval semantics
> I tend to treat a thumbs up as a casual ACK or +1, and an approval as
> a more in-depth review roughly corresponding to the "pending" tag in
> the BTS.
>
> Of course, that's just my approximate usage of the MR features on
> salsa.
I agree. This is my mental model:
Approve = I approve it being merged (but I leave merging to the author
or another reviewer)
+1 = I like the idea and hope cheer the author for working on it
GitLab documentation does not define what these officially mean, but
the Approver status can be used to automate actions/rules and to
filter for MRs pending approval.
By the way, if you plan to review (or later re-review) something, it
would be good if you mark yourself as reviewer. That way it is easier
to use filters like
https://salsa.debian.org/groups/go-team/-/merge_requests/?sort=updated_desc&state=opened&reviewer_id=None&first_page_size=20
to find MRs on the Go team where the author is waiting to get a
reviewer.
Reply to: