On Thu, 2025-08-21 at 08:32 +0200, Simon Josefsson wrote: > Otto Kekäläinen <otto@debian.org> writes: > > > > FWIW, I did a light review and found your merge requests extremely well > > > done, and couldn't even find any nits, so +1 for an upload. > > > > Could you click "Approve" in the MRs themselves or put your comments there? > > > > People who look at open and unreviewed MRs via > > https://salsa.debian.org/groups/go-team/-/merge_requests will not know > > if you reviewed them unless there is some trace of it on the MR > > itself. Thanks! > > I did click thumbs up on the requests. What is the semantics of > clicking 'Approve'? Do we need some Debian or Go team policy on what it > is supposed to mean? What I am supposed to do as clicking on that > button? What are readers supposed to infer from people who clicked on > that button? Anyway I clicked it now, but I'm not sure what it imply. I tend to treat a thumbs up as a casual ACK or +1, and an approval as a more in-depth review roughly corresponding to the "pending" tag in the BTS. Of course, that's just my approximate usage of the MR features on salsa. Mathias
Attachment:
signature.asc
Description: This is a digitally signed message part