[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Planning to upload new version of dh-golang and dh-make-golang end of month



Hi!

[ Wearing two hats, @sipwise.com and @debian.org. :) ]

On Mon, 2025-01-20 at 09:07:48 +0100, Simon Josefsson wrote:
> Otto Kekäläinen <otto@debian.org> writes:
> > > One question: we are changing s/Built-Using/Static-Built-Using/, is that
> > > the right thing?  It seems like a rather big semantic change, so I
> > > wanted to ask a confirming question that this is really intended.
> >
> > You are referring to
> > https://github.com/Debian/dh-make-golang/commit/41082910a118087a4f10f6f1ced311c3b58147f2
> > by Gulliem in August 2024.
> >
> > This Static-Built-Using: ${misc:Static-Built-Using} seems correct
> > based on discussions on this mailing list, but I guess the final form
> > was still somewhat in open?

We have been manually switching packages to use that new field and
substvars. I'm not sure what you mean with the final form being open,
could you clarify?

The one thing I had pending (@sipwise.com), where I've got some code
laying around in my dh-golang git checkout, is to mark the
misc:Built-Using substvar as optional (using the new ?= syntax,
described in deb-substvars(5)), so that we do not get warnings due to
dh-golang setting that substvar but the debian/control file not making
use of it (and to prevent people then acting on the warning and adding
it back or something).

But ideally this would imply adding (@debian.org) a new
set_as_optional() method to Dpkg::Substvars (which I might already
have somewhere perhaps), and a new dpkg upload, as debhelper does not
provide such interface, and I (@sipwise.com) would rather not
reimplement that module in dh-golang.

(But neither of the above seems overly pressing TBH.)

> Okay, thanks for the reference, I assume we will find out if it breaks
> anything eventually.  I found this one too:
> 
> https://wiki.debian.org/Static-Built-Using
> 
> I suppose the man page is still correct, or?
> 
> https://salsa.debian.org/go-team/packages/dh-golang/-/blob/bc16dff5381b668a71fa99c381baba202c34c789/script/dh_golang#L31

Yes, this still requires us to switch existing packages to use the new
field and new substvar. The compat code can be removed once no packages
refer it.

Thanks,
Guillem


Reply to: