[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Planning to upload new version of dh-golang and dh-make-golang end of month



Otto Kekäläinen <otto@debian.org> writes:

> Hi all!
>
> I plan to upload dh-golang and dh-make-golang to Debian unstable by
> the end of the month to get all the new features in use.

I support making an upload earlier, to more strongly trigger review by
the code.  For easier review, everyone can use this link:

https://github.com/Debian/dh-make-golang/compare/v0.7.0...master

I read through the diff, and either didn't understand changes (neutral)
or is supportive of them.  I will only realize if I have an objection to
the things I'm neutral on when I start to use the new version.

One question: we are changing s/Built-Using/Static-Built-Using/, is that
the right thing?  It seems like a rather big semantic change, so I
wanted to ask a confirming question that this is really intended.

Why don't 'dh-make-golang make -wrap-and-sort' accept any valid
wrap-and-sort parameter?  I would prefer if our default instead of
'-sat' was -satbk'.  The -b for --sort-binary-packages make the ordering
of debian/control packages more reliable, and -k for --keep-first make
sure the first one is not re-ordered because the first binary package in
debian/control has magic properties so shouldn't be re-sorted
automatically.  For most Go packages, the behaviour is identical.

/Simon

> I would appreciate it if team members can review open PRs/MRs so we
> get as many improvements as possible included in this upload:
>
> https://github.com/Debian/dh-make-golang/pulls (13 open)
> https://salsa.debian.org/go-team/packages/dh-golang/-/merge_requests (4 open)
>

Attachment: signature.asc
Description: PGP signature


Reply to: