Bug#1033467: unblock: golang-github-yuin-goldmark/1.5.4-1
Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock
X-Debbugs-Cc: golang-github-yuin-goldmark@packages.debian.org, debian-go@lists.debian.org, foka@debian.org
Control: affects -1 + src:golang-github-yuin-goldmark
Please unblock package golang-github-yuin-goldmark
[ Reason ]
golang-github-yuin-goldmark/1.5.4-1 contains two bug fixes:
* ARIA role attribute in Markdown content is not rendered
https://github.com/gohugoio/hugo/issues/10661
https://github.com/yuin/goldmark/issues/357
* Blockquote tag appears after HTML not ending with newline
https://github.com/yuin/goldmark/issues/361
and this version is specified in hugo/0.111.3-1 go.mod as its dependency.
[ Impact ]
If the unblock isn't granted, hugo/0.111.3-1 and other bug-fix uploads for
other packages would not be able to migrate Debian 12 bookworm.
[ Tests ]
I used ratt to test rebuild of all 193 packages that directly
or indirectly depend on golang-github-yuin-goldmark.
All 193 packages passed except for the following 5:
FAILED: dnscrypt-proxy (see buildlogs/dnscrypt-proxy_2.0.45+ds1-1)
FAILED: gitaly (see buildlogs/gitaly_13.4.6+dfsg1-2)
FAILED: nomad (see buildlogs/nomad_0.12.10+dfsg1-3)
FAILED: nomad-driver-podman (see buildlogs/nomad-driver-podman_0.1.0-2)
FAILED: golang-github-prometheus-common (see buildlogs/golang-github-prometheus-common_0.15.0-2)
The first 4 (dnscrypt-proxy, gitaly, nomad, nomad-driver-podman)
currently FTBFS and were removed from testing/bookworm some time ago.
(I've just uploaded an NMU for dnscrypt-proxy as its FTBFS is trivial to
fix.)
The last one "golang-github-prometheus-common" failed because dose-ceve
(which ratt uses) incorrectly returned the version in stable/bullseye.
Rebuilding for golang-github-prometheus-common_0.39.0-2 manually with
the following command completes successfully:
sbuild --arch-all --dist=unstable --nolog \
golang-github-prometheus-common_0.39.0-2 \
--extra-package=../golang-github-yuin-goldmark-dev_1.5.4-1_all.deb
[ Risks ]
I must admit I did not know that golang-github-yuin-goldmark is marked
as a key package, but with the successful "ratt" rebuild of all affected
packages, as well as the minimal bug fixes that simply corrects its HTML
output, there is no risk in upgrading golang-github-yuin-goldmark from
1.5.3-1 to 1.5.4-1.
[ Checklist ]
[x] all changes are documented in the d/changelog
[x] I reviewed all changes and I approve them
[x] attach debdiff against the package in testing
unblock golang-github-yuin-goldmark/1.5.4-1
Many thanks!
Anthony Fok
diff -Nru golang-github-yuin-goldmark-1.5.3/debian/changelog golang-github-yuin-goldmark-1.5.4/debian/changelog
--- golang-github-yuin-goldmark-1.5.3/debian/changelog 2023-01-23 07:12:53.000000000 -0700
+++ golang-github-yuin-goldmark-1.5.4/debian/changelog 2023-03-08 19:19:12.000000000 -0700
@@ -1,3 +1,9 @@
+golang-github-yuin-goldmark (1.5.4-1) unstable; urgency=medium
+
+ * New upstream version 1.5.4
+
+ -- Anthony Fok <foka@debian.org> Wed, 08 Mar 2023 19:19:12 -0700
+
golang-github-yuin-goldmark (1.5.3-1) unstable; urgency=medium
* New upstream version 1.5.3
diff -Nru golang-github-yuin-goldmark-1.5.3/parser/html_block.go golang-github-yuin-goldmark-1.5.4/parser/html_block.go
--- golang-github-yuin-goldmark-1.5.3/parser/html_block.go 2022-11-12 04:13:03.000000000 -0700
+++ golang-github-yuin-goldmark-1.5.4/parser/html_block.go 2023-02-02 05:02:21.000000000 -0700
@@ -149,7 +149,7 @@
}
}
if node != nil {
- reader.Advance(segment.Len() - 1)
+ reader.Advance(segment.Len() - util.TrimRightSpaceLength(line))
node.Lines().Append(segment)
return node, NoChildren
}
@@ -172,7 +172,7 @@
}
if htmlBlockType1CloseRegexp.Match(line) {
htmlBlock.ClosureLine = segment
- reader.Advance(segment.Len() - 1)
+ reader.Advance(segment.Len() - util.TrimRightSpaceLength(line))
return Close
}
case ast.HTMLBlockType2:
@@ -211,7 +211,7 @@
}
}
node.Lines().Append(segment)
- reader.Advance(segment.Len() - 1)
+ reader.Advance(segment.Len() - util.TrimRightSpaceLength(line))
return Continue | NoChildren
}
diff -Nru golang-github-yuin-goldmark-1.5.3/README.md golang-github-yuin-goldmark-1.5.4/README.md
--- golang-github-yuin-goldmark-1.5.3/README.md 2022-11-12 04:13:03.000000000 -0700
+++ golang-github-yuin-goldmark-1.5.4/README.md 2023-02-02 05:02:21.000000000 -0700
@@ -446,6 +446,8 @@
- [goldmark-embed](https://github.com/13rac1/goldmark-embed): Adds support for rendering embeds from YouTube links.
- [goldmark-latex](https://github.com/soypat/goldmark-latex): A $\LaTeX$ renderer that can be passed to `goldmark.WithRenderer()`.
- [goldmark-fences](https://github.com/stefanfritsch/goldmark-fences): Support for pandoc-style [fenced divs](https://pandoc.org/MANUAL.html#divs-and-spans) in goldmark.
+- [goldmark-d2](https://github.com/FurqanSoftware/goldmark-d2): Adds support for [D2](https://d2lang.com/) diagrams.
+- [goldmark-katex](https://github.com/FurqanSoftware/goldmark-katex): Adds support for [KaTeX](https://katex.org/) math and equations.
goldmark internal(for extension developers)
diff -Nru golang-github-yuin-goldmark-1.5.3/renderer/html/html.go golang-github-yuin-goldmark-1.5.4/renderer/html/html.go
--- golang-github-yuin-goldmark-1.5.3/renderer/html/html.go 2022-11-12 04:13:03.000000000 -0700
+++ golang-github-yuin-goldmark-1.5.4/renderer/html/html.go 2023-02-02 05:02:21.000000000 -0700
@@ -244,6 +244,7 @@
[]byte("itemtype"),
[]byte("lang"),
[]byte("part"),
+ []byte("role"),
[]byte("slot"),
[]byte("spellcheck"),
[]byte("style"),
diff -Nru golang-github-yuin-goldmark-1.5.3/_test/extra.txt golang-github-yuin-goldmark-1.5.4/_test/extra.txt
--- golang-github-yuin-goldmark-1.5.3/_test/extra.txt 2022-11-12 04:13:03.000000000 -0700
+++ golang-github-yuin-goldmark-1.5.4/_test/extra.txt 2023-02-02 05:02:21.000000000 -0700
@@ -741,3 +741,14 @@
</li>
</ol>
//= = = = = = = = = = = = = = = = = = = = = = = =//
+
+
+58: HTML end tag without trailing new lines
+ OPTIONS: {"trim": true}
+//- - - - - - - - -//
+<pre>
+</pre>
+//- - - - - - - - -//
+<pre>
+</pre>
+//= = = = = = = = = = = = = = = = = = = = = = = =//
Reply to: