Re: [RFS] -- golang-github-zyedidia-pty

[Bo YU <tsu.yubo@gmail.com>]

hi!

On Fri, Sep 22, 2023 at 9:03 PM Nilesh Patra <nilesh@debian.org> wrote:
>
> On Fri, Sep 22, 2023 at 05:35:50PM +0800, Bo YU wrote:
> > It is time to update zyedidia-terminal here. But something else need
> > to be updated also I think.
> >
> > The reason why to update these go packages is due to #1032265[0].
> > Now micro has switched to creack/pty[1]
> >
> > micro build dependence on golang-github-zyedidia-terminal-dev and
> > golang-github-zyedidia-pty-dev.
> > golang-github-zyedidia-terminal-dev dependence on
> > golang-github-zyedidia-pty-dev.
> > Now the zyedidia/terminal and mciro upstream has switched to creack/pty[2] [3].
> >
> > So we can update golang-github-zyedidia-terminal-dev[4] and micro[5]
> > and remove golang-github-zyedidia-pty.
> >
> > But these update do not fix my final goal: to fix FTBFS on riscv64 for
> > micro due to the issue[6]. Now the micro
> > has new upstream version and i think this is a chance to fix the FTBFS issue.
> >
> > I can confirm the micro(2.0.12) can be built with
> > golang-github-zyedidia-terminal which has switch to creack-pty.
> > Another thing is that need to upgrade golang-github-zyedidia-tcell also.
> >
> > In other words, in order to fix FTBFS on riscv64 for micro, I have to
> > update two go -dev packages and then
> > update micro also. Once I get the ack, I will start the work.
> >
> > What are your options here? :)
>
> Sounds good to me, please proceed ahead!
1. I have updated golang-github-zyedidia-tcell first[0]
Because the upgrading is not harmful, micro 2.0.11 and 2.0.12 both can
be built with it.
Please notice I have to change d/watch to fetch the newest version for
zyedidia-tcell[1]
[0]: https://salsa.debian.org/go-team/packages/golang-github-zyedidia-tcell
[1]: https://github.com/zyedidia/micro/blob/master/go.mod#L17

2. It was stuck to upgrade micro or golang-github-zyedidia-terminal-dev.
for example: now micro(2.0.11-3) and
golang-github-zyedidia-terminal-dev(0.0~git20180726.533c623-2).
micro(2.0.12-1) will not be built with
golang-github-zyedidia-terminal-dev(0.0~git20180726.533c623-2)
or micro(2.0.11-3) will bot built with
golang-github-zyedidia-terminal-dev(0.0~git20230315.4b3bcf6)
but micro(2.0.12-1) can be built with
golang-github-zyedidia-terminal-dev(0.0~git20230315.4b3bcf6)
with updated golang-github-zyedidia-tcell.

I think I should update golang-github-zyedidia-terminal-dev and then
upload micro in a short time.

Can this be done?

BR,
Bo
>
>
> Best,
> Nilesh