Re: [RFS] -- golang-github-zyedidia-pty
- To: Nilesh Patra <nilesh@mailbox.org>
- Cc: debian-go@lists.debian.org
- Subject: Re: [RFS] -- golang-github-zyedidia-pty
- From: Bo YU <tsu.yubo@gmail.com>
- Date: Fri, 22 Sep 2023 17:35:50 +0800
- Message-id: <[🔎] CAKq8=3Kz56TUzFY6=F-GdxdTnKAp4ONTvY0sryntJaYm2vVsbg@mail.gmail.com>
- In-reply-to: <2103851320.455491.1686683236202@office.mailbox.org>
- References: <20230315130709.znpftimksx3b5fnj@debian> <348366699.199675.1679629839534@office.mailbox.org> <710507505.382844.1686595489092@office.mailbox.org> <CAKq8=3JT-73oV4NwPupGVxA5sZxLMRf=6FNgg37UaS_cGb1BdQ@mail.gmail.com> <F416B69A-A27A-4932-8E3C-55A49370FD63@mailbox.org> <CAKq8=3L-9xyih2Qcj1pm1vbJgKHMRP1aCuu=EWB9=n+5dpunCg@mail.gmail.com> <2103851320.455491.1686683236202@office.mailbox.org>
hi!
On Wed, Jun 14, 2023 at 3:07 AM Nilesh Patra <nilesh@mailbox.org> wrote:
>
> On 06/13/2023 1:08 PM IST Bo YU <tsu.yubo@gmail.com> wrote:
> > On Tue, Jun 13, 2023 at 1:03 PM Nilesh Patra <nilesh@mailbox.org> wrote:
> > > Yes. Would you like to package creak-pty?
> > If this is correct, we have packaged the creack-pty?
> > https://tracker.debian.org/pkg/golang-github-creack-pty
>
> Oh, right. I missed seeing this in a hurry. Thanks for pointing this out!
>
> > > I don't think it makes sense to do more work on zyedidia-pty given that it would be removed at some point.
> > >
> > This is my point here also. So the next thing is I should update
> > golang-github-zyedidia-terminal. Once done,
> > we can remove golang-github-zyedidia-pty.
>
> Sure! Do ping here once you update zyedidia-terminal.
Update:
It is time to update zyedidia-terminal here. But something else need
to be updated also I think.
The reason why to update these go packages is due to #1032265[0].
Now micro has switched to creack/pty[1]
micro build dependence on golang-github-zyedidia-terminal-dev and
golang-github-zyedidia-pty-dev.
golang-github-zyedidia-terminal-dev dependence on
golang-github-zyedidia-pty-dev.
Now the zyedidia/terminal and mciro upstream has switched to creack/pty[2] [3].
So we can update golang-github-zyedidia-terminal-dev[4] and micro[5]
and remove golang-github-zyedidia-pty.
But these update do not fix my final goal: to fix FTBFS on riscv64 for
micro due to the issue[6]. Now the micro
has new upstream version and i think this is a chance to fix the FTBFS issue.
I can confirm the micro(2.0.12) can be built with
golang-github-zyedidia-terminal which has switch to creack-pty.
Another thing is that need to upgrade golang-github-zyedidia-tcell also.
In other words, in order to fix FTBFS on riscv64 for micro, I have to
update two go -dev packages and then
update micro also. Once I get the ack, I will start the work.
What are your options here? :)
BR,
Bo
[0]: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1032265
[1]: https://github.com/zyedidia/micro/blob/master/go.sum#LL6C4-L6C4
[2]: https://github.com/zyedidia/terminal/blob/master/go.mod
[3]: https://github.com/zyedidia/micro/blob/master/go.sum#L6
[4]: https://salsa.debian.org/go-team/packages/golang-github-zyedidia-terminal/-/blob/debian/sid/debian/control#L12
[5]: https://salsa.debian.org/go-team/packages/micro/-/blob/debian/sid/debian/control#L25
[6]: https://github.com/zyedidia/micro/issues/2854
>
> > > >[0]: https://github.com/zyedidia/micro/blob/master/go.sum#LL6C4-L6C4
> > > >[1]: https://github.com/zyedidia/terminal/blob/master/go.sum#LL1
> > > >[2]: https://lists.debian.org/debian-go/2023/03/msg00045.html
>
> Best,
> Nilesh
Reply to: