Re: RFS: golang-github-jesseduffield-go-git/5.1.2+git20221018.fdd53fe-1 [ITP]
Hi Arun Kumar Pariyar,
Many thanks for your careful review.
On Sat, 9 Sept 2023 at 03:25, Arun Kumar Pariyar <arun@debian.org> wrote:
> I went through your package and I suggest you to fix some of the issues below.
>
> * Add debian/upstream/metadata.
Now added, to all my RFSes.
> * Remove plumbing/format/packfile/.packfile_test.go.swp and repack your source.
My mistake. Now removed. Many thanks!
> * Update debian/copyright information for plumbing/format/index/match.go
> as the code is mostly copied from golang src. [1]
Added the missing copyright information.
> * Also, you may want to consider applying `wrap-and-sort`.
Now applied, to all my RFSes.
Could you please review again? Thanks!
Sincerely,
Jongmin.
--
Jongmin Kim
OpenPGP key located at https://jongmin.dev/pgp
OpenPGP fingerprint: 012E 4A06 79E1 4EFC DAAE 9472 D39D 8D29 BAF3 6DF8
Reply to: