Hi Jongmin Kim, On 08/09/2023 00:51, Jongmin Kim wrote:
Could you please reviewing/sponsoring this? Any kind of reviews and suggestions are appreciated.
I went through your package and I suggest you to fix some of the issues below. * Add debian/upstream/metadata. * Remove plumbing/format/packfile/.packfile_test.go.swp and repack your source. * Update debian/copyright information for plumbing/format/index/match.go as the code is mostly copied from golang src. [1] * Also, you may want to consider applying `wrap-and-sort`. [1] https://github.com/golang/go/blob/39852bf4cce6927e01d0136c7843f65a801738cb/src/path/filepath/match.go#L44-L224 Regards, ~ Arun Kumar Pariyar
Attachment:
OpenPGP_0x4B542AF704F74516.asc
Description: OpenPGP public key
Attachment:
OpenPGP_signature
Description: OpenPGP digital signature