Re: [RFS] -- golang-github-go-enry-go-oniguruma

[Vinay <vinaykeshava@disroot.org>]

On 17/02/23 08:33, Nilesh Patra wrote:
> > > Here's the review:
> > >
> > > 1. Please fix copyright. The author stated in LICENSE and d/copyr do not
> > > match. Other than that, there is a different author mentioned in
> > > regex_test.go which needs to be mentioned in d/copyright.
> > Added
> > Files: regex_test.go
> > Copyright: 2009, The Go Authors.
> > License: BSD-3-clause
> You need to change the author of "Files: *" as well. It does not match
> with what is specified in LICENSE file.
>
> > > 2. As per readme, this package should also have a "Depends" on libonig-dev, but please double check.
> > > The tests otherwise fail for me with:
> > > | # github.com/go-enry/go-oniguruma
> > > | ./regex.go:7:10: fatal error: oniguruma.h: No such file or directory
> > > |    7 | #include <oniguruma.h>
> > > |          ^~~~~~~~~~~~~
> > > | compilation terminated
> > Have added the libonig-dev to Depends builds in clean chroot environment.
> >
> > I don't see anything new in salsa, please push your changes.
Have pushed changes
please review it

> have these been cleaned up?
yes updated the standards-version.