[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: golang-github-aybabtme-rgbterm/0.0~git20170906.cc83f3b-1 [ITP] -- RGB colors for your terminal (library)



On 8/8/22 8:11 AM, braulio wrote:
Good evening,> I will answer with the numbered items to make it easier to understand according to the questions:

Or you could simply bottom-post instead[0] (like I am doing)
1) Sorry, the correct link Vcs is:
https://salsa.debian.org/go-team/packages/golang-github-aybabtme-rgbterm

2) I open New Issue, asking what is the correct version of the license in https://github.com/aybabtme/rgbterm/issues/8

Thanks.
It seems that the repository from where the source was copied (code.google.com/gorilla) is no longer present and
it has moved to github at github.com/gorilla.
However there is no "color" repository there. On searching a bit, I found an old copy of this embedded in another
project[1] which follows the same license as mentioned in rgbterm repository which is clearly BSD-3.

I'd suggest mentioning BSD-3 in d/copyright, along with a "Comment:" of why that might be. Will see what
FTP masters think about this.

3) I got confused by adding the rgbterm.go file with the BSD 2 clause license, the correct file is the util.go file that contains the parts
for "RGB <-> HSL helpers" licensed under BSD 2 clause and fixed in debian/copyright. I just don't know if I made the correct indication in
the debian/copyright file and any corrections or suggestions for improvement you can let me know that I will correct it.

The license here[2] should be "BSD-3-Clause and Expat" - please take a look at copyright wiki once.
And you seem to have patched 'upstream' LICENSE file in this commit[3] - please never do that, it is always wrong to do so.


Lastly: rgbterm seems abandoned upstream, last commit was ~6 years ago. Why do you want to get it in the archive? Is this
a dependency of a bigger project you are working on?


[0]: https://en.wikipedia.org/wiki/Posting_style#Bottom-posting
[1]: https://github.com/pruthvirajsinh/prlpks/blob/master/build/src/code.google.com/p/gorilla/color
[2]: https://salsa.debian.org/go-team/packages/golang-github-aybabtme-rgbterm/-/commit/b0e64796a76ac6e96915af4f154a744ea86ddd10#adb7f75f79e3bb85eb62912a2904c5d24af878fb_13_14
[3]: https://salsa.debian.org/go-team/packages/golang-github-aybabtme-rgbterm/-/commit/ed408c38b26436eec4c5d4f6bce197a4678b08ff

--
Best,
Nilesh

Attachment: OpenPGP_signature
Description: OpenPGP digital signature


Reply to: