[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Packaging Amfora and dependencies

On Sun, Mar 14, 2021 at 10:36:02PM -0700, Micheal Waltz wrote:
> Debian Go Packaging Team,
> I've been working on a few new packages for Gemini
> (https://gemini.circumlunar.space); Bombadillo and Amfora, which
> are both terminal based browsers written in Go.

Thank you Nilesh for working with me on getting all of these packages
built and uploaded.

Now that all the dependencies are on their way into unstable I've come
back to packaging Amfora.

Two things I've encountered if you could please help me.

First is I missed the dependency, go-isemoji. Following packaging
guidelines to the other deps, it's in Salsa and mentors if you could
please review and sponsor.

Salsa repo: https://salsa.debian.org/go-team/packages/golang-github-makeworld-the-better-one-go-isemoji/-/tree/master
Mentors: https://mentors.debian.net/package/golang-github-makeworld-the-better-one-go-isemoji/
ITP: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=986687

Let me know if you'd like me to file a RFS as well.

Second is building Amfora with the --extra-packages and the new deps in unstable.
However it's failing to build with an undefined error.

Everything is up-to-date on Salsa,

Build command:

gbp buildpackage --git-ignore-new --git-builder=sbuild -A -v --source -d unstable --extra-package ~/debian/cbind/golang-code.rocketnine-tslocum-cbind-dev_0.1.5-1_all.deb --extra-package ~/debian/cview/golang-code.rocketnine-tslocum-cview-dev_1.5.4-1_all.deb --extra-package ~/debian/go-isemoji/golang-github-makeworld-the-better-one-go-isemoji-dev_1.1.0-1_all.deb

Error (full error log: https://salsa.debian.org/go-team/packages/amfora/-/snippets/539):

# github.com/makeworld-the-better-one/amfora/subscriptions
src/github.com/makeworld-the-better-one/amfora/subscriptions/entries.go:49:11: item.Links undefined (type *gofeed.Item has no field or method Links)
src/github.com/makeworld-the-better-one/amfora/subscriptions/entries.go:104:27: item.Links undefined (type *gofeed.Item has no field or method Links)
src/github.com/makeworld-the-better-one/amfora/subscriptions/subscriptions.go:169:6: feed.Links undefined (type *gofeed.Feed has no field or method Li
dh_auto_build: error: cd obj-x86_64-linux-gnu && go install -trimpath -v -p 12 github.com/makeworld-the-better-one/amfora github.com/makeworld-the-bet
ter-one/amfora/bookmarks github.com/makeworld-the-better-one/amfora/cache github.com/makeworld-the-better-one/amfora/client github.com/makeworld-the-b
etter-one/amfora/config github.com/makeworld-the-better-one/amfora/display github.com/makeworld-the-better-one/amfora/logger github.com/makeworld-the-
better-one/amfora/renderer github.com/makeworld-the-better-one/amfora/rr github.com/makeworld-the-better-one/amfora/structs github.com/makeworld-the-b
etter-one/amfora/subscriptions github.com/makeworld-the-better-one/amfora/sysopen github.com/makeworld-the-better-one/amfora/webbrowser returned exit
code 2
make: *** [debian/rules:7: build] Error 25
dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2

Any ideas on why this is failing? I did build Amfora from the v1.8.0 tag
in a fresh debian:unstable container with go1.15.9 and it didn't have
any errors.

Maybe because the patch is using slightly newer versions of cview/cbind
than what 1.8.0 had? Although this failure is in subscriptions/entries.go
which doesn't have any godeps for cview/cbind that I can tell and seems
like an unrelated error.

Thank you,

Micheal Waltz
GPG Fingerprint: 5F70 F2AC BD58 F580 DF15  3D1F 4FA2 70F5 CD36 71F9

Attachment: signature.asc
Description: PGP signature

Reply to: