[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Please Review / Upload golang-github-xenolf-lego


On Sun, Jan 31, 2021 at 2:57 AM Félix Sipma <felix+debian@gueux.org> wrote:
> https://mentors.debian.net/debian/pool/main/g/golang-github-minio-minio-go/golang-github-minio-minio-go_7.0.5-1.dsc
> https://salsa.debian.org/go-team/packages/golang-github-minio-minio-go

I'm going to review this first. Since both packages have major version
bump, and change of import path.
As it doesn't introduce a new package with -v7 suffix. So it should be
handled more carefully to avoid the current mess like the testing
migration of golang-github-xenolf-lego and golang-github-nrdcg-goinwx.

1. It needs to have Breaks in -dev package.


   You can see both  gitlab-ci-multi-runner and restic use /v6 import
path. So you need to have:

   Breaks: gitlab-ci-multi-runner (<< the-further-version-fixed),
restic (<< the-further-version-fixed)

2. Prepare and upload fixed gitlab-ci-multi-runner too.

Some more bonus if you can:
3. Update the team mail address, Section, Standards-Version
4. Remove unused depends, like golang-github-go-ini-ini-dev

Shengjing Zhu

Reply to: