Re: RFS for 6 go packages

[Andreas Henriksson <andreas@fatal.se>]

Hello again,

On Sun, Mar 22, 2020 at 09:12:09PM +0530, Nilesh Patra wrote:
[...]
> * golang-go.uber-zap [3] - This also has RFA, and hence I have added my
> name to uploaders.
[...]
> [3]: https://salsa.debian.org/go-team/packages/golang-go.uber-zap
[...]

The upstream/1.14.1 tag is missing in the git repo, please make sure to
push tags. (gbp push will help you DTRT. Also as you mentioned I agree
it's better if the uploader pushes the debian/* tag when the package
is actually uploaded, but other tags like upstream/* you really have
to push. OTOH it's also ok by me if you push the debian/* tag. When
you're the maintainer you decide about releases, even if some of them
mighht never make it into the official archive.)

Some things to note that would make it easier for a drive-by sponsor
like me to review your work:

* New upstream release.

  I don't trust golang stuff to not break API every release, so please
  tell me (in your RFS) if you've:
   - investigated possible API breaks
   - tested building reverse dependencies (see ratt)
   - any other useful info related to the new release that I should be
     aware of (like any particular reason for updating it).

* debian/compat to debhelper-compat

  - You forgot to mention that you also bumped compat from 10 to 12!
    This is more important to mention than changing from file to
    virtual package dep. (See also lintian-brush which will help
    you do these kinds of changes and DTRT with commit messages.)

* debian/copyright changes

  Please mention all changes in debian/changelog !!!
  The commit message doesn't help me much either. Please write good
  commit messages describing not only what you did but also why.
  Please use 'gbp dch' to generate debian/changelog which will
  help you make sure to mention all changes in the changelog
  as well as making sure your commit messages has the quality
  that is expected from debian/changelog messages.
  I still don't know if I agree with dropping the Files-Excluded
  change (and also don't know your reason for doing that).

I guess these are all minor nitpicks and I can probably find more even
smaller ones, but as mentioned... everyone is busy and sponsorship
is a limited resource, so please make your stuff easy to review. Making
it easy for sponsors means you get more of your stuff sponsored.

Regards,
Andreas Henriksson