Re: RFS for 6 go packages
Hello Nilesh Patra,
Thanks alot for looking into solving FTBFS (and other) issues.
On Sun, Mar 22, 2020 at 09:12:09PM +0530, Nilesh Patra wrote:
> Hi,
> I have fixed RC-Bugs (FTBFS) with 3 Packages:
>
> * golang-github-akrennmair-gopcap [1]
Uploaded. ^^^
> * golang-github-boltdb-bolt [2]
Looking at this now. Apparently I've previously commented
on the FTBFS bug report at:
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=952199#12
Did the upstream commit I pointed at not actually fix the problem?
In general would be nice if you could note the 'forwarded' status
when you add patches (see DEP-3). Have you submitted them upstream (and
if so where)? Are there already upstream commits fixing this issue (and
if so which one did you use? Why did you not use it? etc)? Personally
I'm very much inclined to cherry-pick upstreams commits fixing issues
rather than solving it on your own (if there's an upstream fix which
isn't very messy to cherry-pick).
I'm not really able to tell which is the better way to solve the
problem. I guess I'll go ahead an upload your patch as being able
to build is good and hopefully the patch should just be dropped once
a new upstream release is imported. Please comment on your patches in
the future making it easier for reviewers to know their status.
Will look at the rest when/if I find time...
> * golang-go.uber-zap [3] - This also has RFA, and hence I have added my
> name to uploaders.
>
> These three packages have RFA, and have been lying un-updated, I have
> updated them and added myself to uploaders:
>
> * golang-github-glycerine-go-unsnap-stream [4]
> * golang-github-influxdata-influxql [5]
> * golang-github-jackpal-gateway [6]
>
> Some of them have CI tests failing, but judging from the tail logs, it
> looks like because they were updated to new upstream and the corresponding
> tags (upstream/ + debian/) have not been pushed.
> I haven't pushed because the uploader pushes the tags.
> It should be fine once updated tags are pushed.
>
> I have pushed all my changes to the respective team repos, links can be
> found below.
> Need review+sponsorship.
>
> [1]:
> https://salsa.debian.org/go-team/packages/golang-github-akrennmair-gopcap
> [2]: https://salsa.debian.org/go-team/packages/golang-github-boltdb-bolt
> [3]: https://salsa.debian.org/go-team/packages/golang-go.uber-zap
> [4]:
> https://salsa.debian.org/go-team/packages/golang-github-glycerine-go-unsnap-stream
> [5]:
> https://salsa.debian.org/go-team/packages/golang-github-influxdata-influxql
> [6]: https://salsa.debian.org/go-team/packages/golang-github-jackpal-gateway
>
> Thanks and regards,
> Nilesh
Reply to: