Re: RFS: golang-github-tonistiigi-fsutil
On Sat, Apr 4, 2020 at 9:55 AM Tong Sun
<suntong001@users.sourceforge.net> wrote:
>
> On Sat, Mar 21, 2020 at 11:43 AM Tong Sun
> <suntong001@users.sourceforge.net> wrote:
> >
> > On Mon, Mar 9, 2020 at 3:44 PM Tong Sun
> > <suntong001@users.sourceforge.net> wrote:
> > >
> > > On Mon, Mar 9, 2020 at 3:31 PM Utkarsh Gupta <utkarsh@debian.org> wrote:
> > >
> > > > > > While you're at it Utkarsh, please check out golang-github-tonistiigi-fsutil at
> > > > > > https://salsa.debian.org/suntong-guest/golang-github-tonistiigi-fsutil
> > > > > ops, I meant https://salsa.debian.org/go-team/packages/golang-github-tonistiigi-fsutil
> > > > > > I just pushed it and it should be all clean as well.
> > > >
> > > > This doesn't seem to build for me. I get some test failures when running sbuild.
> > > > Could you check back and confirm?
> > >
> > > Thanks for checking, Utkarsh.
> > >
> > > I just tried again and it works for me. I've put my log here--
> > > https://pastebin.com/YkrJS0Zm
> >
> >
> > OK, in summary, here is the current situation --
> >
> > -----------------------------------------
> > On Tue, Mar 17, 2020 at 2:30 AM Anthony Fok <foka@debian.org> wrote:
> >
> > > 1. Check debian/control and see if "Rules-Requires-Root: no" is set
> > > (now inserted by default by dh-make-golang).
> > > Either remove that line, or, better yet, set it explicitly to
> > > "binary-targets", see
> > > https://www.debian.org/doc/debian-policy/ch-controlfields.html#rules-requires-root
> >
> > Thank for Anthony for looking it this. The Go project is
> > https://salsa.debian.org/go-team/packages/golang-github-tonistiigi-fsutil/-/commits/debian/sid
> >
> > as you can see I've been struggling to make it build.Here are the logs:
> >
> > With Rules-Requires-Root: no:
> > https://dpaste.org/6GqZ
> >
> > With Rules-Requires-Root: yes (or binary-targets):
> > https://dpaste.org/fip4
> >
> > Here is my log,
> > https://paste.debian.net/1134965/
> > and we can see that with root it builds fine.
> > -----------------------------------------
> >
> > I.e., The go package that I'm packing builds OK, but its test failed,
> > because the tests need to be run as root. Proof above. And also,
> >
> > I tried to do `sudo go test` during build, but that failed as well --
> > https://lists.debian.org/debian-go/2020/03/msg00113.html
> >
> > So, to move forward, my plan is,
> >
> > -----------------------------------------
> > > 2. Skip the test(s) that require root access, just like how we skip
> > > the tests that require Internet connection.
> >
> > I think that might be the only last resort. Just that the failed tests
> > are scatting all over the places I haven't figure out a good way of
> > doing that yet.
> > -----------------------------------------
> >
> > - Short term: Skip all the test *files* that will failed during Debian build
> > (as we can see that they all test fine with root).
> > - Long term: Skip all the test *functions* that will failed during Debian build.
> > For this I need to modify upstream, and I've asked if is possible in upstream:
> > https://github.com/tonistiigi/fsutil/issues/76
>
> Update, my fix has made it successful for local build and is now
> accepted upstream.
> Just I'm having problem with the following, which has been asked in a
> fresh thread:
>
> gbp:error: Uscan failed: Filename pattern missing version delimiters
> () without filenamemangle
Should all be fixed. Now buildable as none-root user.
Please give it a try. thx.
Reply to: